Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756039Ab1BXJhW (ORCPT ); Thu, 24 Feb 2011 04:37:22 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:36851 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751987Ab1BXJhU (ORCPT ); Thu, 24 Feb 2011 04:37:20 -0500 Date: Thu, 24 Feb 2011 09:37:17 +0000 From: Mark Brown To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, Liam Girdwood , Yong Shen , Sascha Hauer , Alberto Panizzo Subject: Re: [PATCH] regulator, mc13xxx: Remove pointless test for unsigned less than zero Message-ID: <20110224093717.GG8226@opensource.wolfsonmicro.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: You will contract a rare disease. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 695 Lines: 15 On Wed, Feb 23, 2011 at 11:45:55PM +0100, Jesper Juhl wrote: > The variable 'val' is a 'unsigned int', so it can never be less than zero. > This fact makes the "val < 0" part of the test done in BUG_ON() in > mc13xxx_regulator_get_voltage() rather pointles since it can never have > any effect. > This patch removes the pointless test. > > Signed-off-by: Jesper Juhl Acked-by: Mark Brown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/