Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753989Ab1BXRfn (ORCPT ); Thu, 24 Feb 2011 12:35:43 -0500 Received: from mail.vyatta.com ([76.74.103.46]:43459 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573Ab1BXRfi (ORCPT ); Thu, 24 Feb 2011 12:35:38 -0500 Date: Thu, 24 Feb 2011 09:35:35 -0800 From: Stephen Hemminger To: "Anoop P.A" Cc: davem@davemloft.net, khilman@deeprootsystems.com, cyril@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH] Network driver for PMC-Sierra MSP71xx TSMAC. Message-ID: <20110224093535.744ebaf7@nehalam> In-Reply-To: <1298548660-10546-1-git-send-email-anoop.pa@gmail.com> References: <1298548660-10546-1-git-send-email-anoop.pa@gmail.com> Organization: Vyatta X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.0; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 19 On Thu, 24 Feb 2011 17:27:40 +0530 "Anoop P.A" wrote: > +const char version[] = "pmcmsp_tsmac.c:v2.0 01/09/2007, PMC-Sierra\n"; > +const char cardname[] = "pmcmsp_tsmac"; All data and functions that are only used by this driver should be marked static. > +const char drv_reldate[] = "$Date: 2010/07/15 07:38:59 $"; > +const char drv_file[] = __FILE__; This is bogus noise. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/