Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755952Ab1BXSow (ORCPT ); Thu, 24 Feb 2011 13:44:52 -0500 Received: from wolverine02.qualcomm.com ([199.106.114.251]:31138 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752859Ab1BXSos (ORCPT ); Thu, 24 Feb 2011 13:44:48 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6267"; a="76263874" From: Stephen Boyd To: David Brown Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/4] msm: scm: Mark inline asm as volatile Date: Thu, 24 Feb 2011 10:44:42 -0800 Message-Id: <1298573085-23217-2-git-send-email-sboyd@codeaurora.org> X-Mailer: git-send-email 1.7.4.1.55.gdca3d In-Reply-To: <1298573085-23217-1-git-send-email-sboyd@codeaurora.org> References: <1298573085-23217-1-git-send-email-sboyd@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 39 We don't want the compiler to remove these asm statements or reorder them in any way. Mark them as volatile to be sure. Signed-off-by: Stephen Boyd --- arch/arm/mach-msm/scm.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-msm/scm.c b/arch/arm/mach-msm/scm.c index f4b9bc9..ba57b5a 100644 --- a/arch/arm/mach-msm/scm.c +++ b/arch/arm/mach-msm/scm.c @@ -174,7 +174,7 @@ static u32 smc(u32 cmd_addr) register u32 r0 asm("r0") = 1; register u32 r1 asm("r1") = (u32)&context_id; register u32 r2 asm("r2") = cmd_addr; - asm( + asm volatile( __asmeq("%0", "r0") __asmeq("%1", "r0") __asmeq("%2", "r1") @@ -271,7 +271,7 @@ u32 scm_get_version(void) return version; mutex_lock(&scm_lock); - asm( + asm volatile( __asmeq("%0", "r1") __asmeq("%1", "r0") __asmeq("%2", "r1") -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/