Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756319Ab1BXUPO (ORCPT ); Thu, 24 Feb 2011 15:15:14 -0500 Received: from void.printf.net ([89.145.121.20]:45580 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754598Ab1BXUPM (ORCPT ); Thu, 24 Feb 2011 15:15:12 -0500 Date: Thu, 24 Feb 2011 20:15:04 +0000 From: Chris Ball To: Philip Rakity Cc: "Dong, Chuanxiao" , Jae hoon Chung , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , Kyungmin Park Subject: Re: [PATCH 1/1]mmc: set timeout for SDHCI host before sending busy cmd Message-ID: <20110224201504.GA12913@void.printf.net> References: <20110224111935.GB7169@intel.com> <5D8008F58939784290FAB48F5497519835CE59FE81@shsmsx502.ccr.corp.intel.com> <79DD18D4-C79A-4B08-B9E6-050D7EF2FC3D@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79DD18D4-C79A-4B08-B9E6-050D7EF2FC3D@marvell.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 23 On Thu, Feb 24, 2011 at 10:32:30AM -0800, Philip Rakity wrote: > proposed this a while ago and strongly support just removing the quirk for broken timeout and setting the timeout value to maximum of 0xE. > > This also handles the case of the sd device having a timeout value too low. In my testing I have come across SD cards that do not provide the correct value. > We force our pxa168, pxa910, and mmp2 controllers to have 0xE. Yeah, OLPC's CaFe controller -- which might be the same hardware as yours, actually -- has the same problem. Does anyone know of a reason (beyond strict spec-compliance, I suppose) for honoring the timeout value rather than using 0xE everywhere? If not, I'm willing to try out Philip's suggestion. Thanks, -- Chris Ball One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/