Date: Thu, 24 Feb 2011 14:13:35 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Petr Holasek <pholasek@redhat.com>, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Mel Gorman <mel@csn.ul.ie>, Wu Fengguang <fengguang.wu@intel.com>,
        linux-mm@kvack.org
Subject: Re: [PATCH v2] hugetlbfs: correct handling of negative input to
 /proc/sys/vm/nr_hugepages
Message-Id: <20110224141335.978066c5.akpm@linux-foundation.org>
In-Reply-To: <20110224141034.d2dfb7de.akpm@linux-foundation.org>
References: <4D6419C0.8080804@redhat.com>
	<20110224141034.d2dfb7de.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1181
Lines: 30

On Thu, 24 Feb 2011 14:10:34 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 22 Feb 2011 21:17:04 +0100
> Petr Holasek <pholasek@redhat.com> wrote:
> 
> > When user insert negative value into /proc/sys/vm/nr_hugepages it will 
> > result
> > in the setting a random number of HugePages in system
> 
> Is this true?  afacit the kernel will allocate as many pages as it can
> and will then set /proc/sys/vm/nr_hugepages to reflect the result. 
> That's not random.
> 

Assuming the above to be correct, I altered the changelog thusly:

: When the user inserts a negative value into /proc/sys/vm/nr_hugepages it
: will cause the kernel to allocate as many hugepages as possible and to
: then update /proc/meminfo to reflect this.
:
: This changes the behavior so that the negative input will result in
: nr_hugepages value being unchanged.

and given that, I don't really see why we should change the existing behaviour.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/