Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932085Ab1BYAqM (ORCPT ); Thu, 24 Feb 2011 19:46:12 -0500 Received: from cantor2.suse.de ([195.135.220.15]:59141 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754995Ab1BYAqL (ORCPT ); Thu, 24 Feb 2011 19:46:11 -0500 Date: Thu, 24 Feb 2011 16:43:42 -0800 From: Greg KH To: Belisko Marek Cc: alan@linux.intel.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gma500: Fix compilation error. Message-ID: <20110225004342.GA27647@suse.de> References: <1298539998-6422-1-git-send-email-marek.belisko@open-nandra.com> <20110224171209.GE7925@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3684 Lines: 57 On Thu, Feb 24, 2011 at 08:58:52PM +0100, Belisko Marek wrote: > Hi Greg, > > On Thu, Feb 24, 2011 at 6:12 PM, Greg KH wrote: > > On Thu, Feb 24, 2011 at 10:33:18AM +0100, Marek Belisko wrote: > >> This patch will fix following compilation error: > >> drivers/staging/gma500/psb_drv.c:1635: error: unknown field ‘pci_driver’ specified in initializer > >> drivers/staging/gma500/psb_drv.c:1636: error: unknown field ‘name’ specified in initializer > >> drivers/staging/gma500/psb_drv.c:1636: warning: initialization from incompatible pointer type > >> drivers/staging/gma500/psb_drv.c:1637: error: unknown field ‘id_table’ specified in initializer > >> drivers/staging/gma500/psb_drv.c:1637: warning: excess elements in union initializer > >> drivers/staging/gma500/psb_drv.c:1637: warning: (near initialization for ‘driver.kdriver’) > >> drivers/staging/gma500/psb_drv.c:1638: error: unknown field ‘resume’ specified in initializer > >> drivers/staging/gma500/psb_drv.c:1638: warning: excess elements in union initializer > >> drivers/staging/gma500/psb_drv.c:1638: warning: (near initialization for ‘driver.kdriver’) > >> drivers/staging/gma500/psb_drv.c:1639: error: unknown field ‘suspend’ specified in initializer > >> drivers/staging/gma500/psb_drv.c:1639: warning: excess elements in union initializer > >> drivers/staging/gma500/psb_drv.c:1639: warning: (near initialization for ‘driver.kdriver’) > >> drivers/staging/gma500/psb_drv.c:1640: error: unknown field ‘probe’ specified in initializer > >> drivers/staging/gma500/psb_drv.c:1640: warning: excess elements in union initializer > >> drivers/staging/gma500/psb_drv.c:1640: warning: (near initialization for ‘driver.kdriver’) > >> drivers/staging/gma500/psb_drv.c:1641: error: unknown field ‘remove’ specified in initializer > >> drivers/staging/gma500/psb_drv.c:1641: warning: excess elements in union initializer > >> drivers/staging/gma500/psb_drv.c:1641: warning: (near initialization for ‘driver.kdriver’) > >> drivers/staging/gma500/psb_drv.c:1643: error: unknown field ‘driver’ specified in initializer > >> drivers/staging/gma500/psb_drv.c:1643: warning: excess elements in union initializer > >> drivers/staging/gma500/psb_drv.c:1643: warning: (near initialization for ‘driver.kdriver’) > >> drivers/staging/gma500/psb_drv.c: In function ‘psb_init’: > >> drivers/staging/gma500/psb_drv.c:1664: error: implicit declaration of function ‘drm_init’ > >> drivers/staging/gma500/psb_drv.c: In function ‘psb_exit’: > >> drivers/staging/gma500/psb_drv.c:1669: error: implicit declaration of function ‘drm_exit’ > >> > >> Signed-off-by: Marek Belisko > > > > Odd, how come I'm not hitting these in the staging-next tree?  Is it > > because an api changed in the DRM layer in the linux-next tree? > Yes DRM api was changed: > commit 8410ea3b95d105a5be5db501656f44bbb91197c1 > Author: Dave Airlie > Date: Wed Dec 15 03:16:38 2010 +1000 > > drm: rework PCI/platform driver interface. > > Introduce union kdriver which encapsulate pci_driver struct. > That's cause of error in gma500. Ok, this is going to get messy then, this patch should be held by Stephen in linux-next until we merge stuff with Linus, and then I'll be able to apply it to my tree. So I'll just save it in my queue until that time happens, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/