Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756033Ab1BYHiR (ORCPT ); Fri, 25 Feb 2011 02:38:17 -0500 Received: from mail-qy0-f174.google.com ([209.85.216.174]:54742 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755404Ab1BYHiQ (ORCPT ); Fri, 25 Feb 2011 02:38:16 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=W1KPa3citNNtTYVv+mVrxcQkCav4699qjA7pIja49oPq1KdUjoO/jmZcZi17YFgWLE czvsjytZsbNK2Qe7jD0JgIibKN19CfcHChqe09CLr4PIogwSD/5bDhrCfksq1b3HrqVh NjfHeIeDTgJpGfsg3YXKF/FRSFAkMfNT7TjzQ= MIME-Version: 1.0 In-Reply-To: <4D66BD18.2030207@akamai.com> References: <1298528501-32176-1-git-send-email-johunt@akamai.com> <20110224063749.GV22723@ZenIV.linux.org.uk> <20110224112010.GB23042@quack.suse.cz> <4D66BD18.2030207@akamai.com> Date: Fri, 25 Feb 2011 08:38:15 +0100 Message-ID: Subject: Re: [RFC][PATCH] ext2: Resolve i_nlink race in ext2_rename From: Marco Stornelli To: Josh Hunt Cc: Jan Kara , Al Viro , "linux-ext4@vger.kernel.org" , "sandeen@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1016 Lines: 29 Hi, 2011/2/24 Josh Hunt : > Jan > > I'm not seeing the problem with your patch as was expected since we're > not messing with i_nlink anymore. Al suggested marking the inode as > dirty where we were previously doing the old_inode dec. I believe this > is needed as well since we are updating it's ctime. I've attached a > version marking the inode dirty and it also fixes the comment making > reference to calling inode_dec_link_count(). > > I'm not completely clear on the historical reasons for messing with the > link count of old_inode in the first place. It was just to simulate the > linking and unlinking of the old_inode? > > Thanks > Josh > can we share your test/benchmark? I'd like to add it to my test suite as no-regression test. Marco -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/