Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755673Ab1BYVGM (ORCPT ); Fri, 25 Feb 2011 16:06:12 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:48650 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133Ab1BYVGI (ORCPT ); Fri, 25 Feb 2011 16:06:08 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6268"; a="76758407" X-IronPort-AV: E=Sophos;i="4.62,225,1297065600"; d="scan'208";a="117680418" From: Carl Vanderlip To: davidb@codeaurora.org Cc: Dima Zavin , linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM MSM...), linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] video: msmfb: Put the partial update magic value into the fix_screen struct. Date: Fri, 25 Feb 2011 13:05:47 -0800 Message-Id: <1298667947-22123-1-git-send-email-carlv@codeaurora.org> X-Mailer: git-send-email 1.7.3.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1466 Lines: 38 From: Dima Zavin This can then be tested by userspace to see if the capability is supported. Userspace cannot rely on that value being left in var_screen, since userspace itself can change it. --- drivers/video/msm/msm_fb.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/video/msm/msm_fb.c b/drivers/video/msm/msm_fb.c index 5436aeb..bbf841e 100644 --- a/drivers/video/msm/msm_fb.c +++ b/drivers/video/msm/msm_fb.c @@ -469,6 +469,14 @@ static void setup_fb_info(struct msmfb_info *msmfb) fb_info->var.yoffset = 0; if (msmfb->panel->caps & MSMFB_CAP_PARTIAL_UPDATES) { + /* set the param in the fixed screen, so userspace can't + * change it. This will be used to check for the + * capability. */ + fb_info->fix.reserved[0] = 0x5444; + fb_info->fix.reserved[1] = 0x5055; + + /* This preloads the value so that if userspace doesn't + * change it, it will be a full update */ fb_info->var.reserved[0] = 0x54445055; fb_info->var.reserved[1] = 0; fb_info->var.reserved[2] = (uint16_t)msmfb->xres | -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/