Message-ID: <4D6828B5.6050608@codeaurora.org>
Date: Fri, 25 Feb 2011 14:09:57 -0800
From: Stepan Moskovchenko <stepanm@codeaurora.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7
MIME-Version: 1.0
To: Trilok Soni <tsoni@codeaurora.org>
CC: davidb@codeaurora.org, linux-arm-msm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] msm: iommu: Rework clock logic and add IOMMU bus
 clock control
References: <1298599242-21971-1-git-send-email-stepanm@codeaurora.org> <1298599242-21971-2-git-send-email-stepanm@codeaurora.org> <4D675A42.9090803@codeaurora.org>
In-Reply-To: <4D675A42.9090803@codeaurora.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1593
Lines: 57

On 2/24/2011 11:29 PM, Trilok Soni wrote:
> Hi Steve,

Hello

>> @@ -130,117 +131,134 @@ static int msm_iommu_probe(struct platform_device *pdev)
>>   {
>>   	struct resource *r, *r2;
>>   	struct clk *iommu_clk;
>> +	struct clk *iommu_pclk;
>>   	struct msm_iommu_drvdata *drvdata;
>>   	struct msm_iommu_dev *iommu_dev = pdev->dev.platform_data;
> const please.
>

I am not clear on what you mean. Please be more specific here.

>> +	iommu_pclk = clk_get(NULL, "smmu_pclk");
>> +	if (IS_ERR(iommu_pclk)) {
>> +		ret = -ENODEV;
>> +		goto fail;
>> +	}
> I am not a big fan of this when you have the "device" around. You should just do
>
> iommu_pclk = clk_get(&pdev->dev, NULL);
>
> ...error logic...
>
> iommu_clk = clk_get(&pdev->dev, "iommu_clk");
>
> ...error logic...
>

The pclk is a "special" bus clock and does not have a specific device 
instance associated with it, so passing a device would not be 
appropriate in this case. I pass the device for other clocks that are 
indeed associated with devices, but this is not one of them. I suppose 
we could create 11 or 12 aliases for the pclk and associate it with all 
the IOMMU devices, but I would prefer to avoid doing that as I believe 
the current approach is cleaner.

>> -			ret = -EBUSY;
>> -			goto fail;
>> -		}
>> +	len = r->end - r->start + 1;
>
> resource_size please.
>

Ok


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/