Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750836Ab1BZBQi (ORCPT ); Fri, 25 Feb 2011 20:16:38 -0500 Received: from mail-vw0-f46.google.com ([209.85.212.46]:54229 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717Ab1BZBQg convert rfc822-to-8bit (ORCPT ); Fri, 25 Feb 2011 20:16:36 -0500 MIME-Version: 1.0 In-Reply-To: <20110226001908.GA10777@x61s.reliablesolutions.de> References: <20110221232902.GA3440@x61s.reliablesolutions.de> <20110226001908.GA10777@x61s.reliablesolutions.de> Date: Fri, 25 Feb 2011 17:16:35 -0800 Message-ID: Subject: Re: TX VLAN acceleration on bridges broken in 2.6.37? From: Jesse Gross To: Jan Niehusmann Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "Tantilov, Emil S" , "Kirsher, Jeffrey T" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 30 On Fri, Feb 25, 2011 at 4:19 PM, Jan Niehusmann wrote: > On Fri, Feb 25, 2011 at 02:53:21PM -0800, Jesse Gross wrote: >> is specific to the e1000e driver. ?I know that some other Intel NICs >> require vlan stripping on receive to be enabled for vlan insertion on >> transmit to work. ?Since this driver has not been converted over to >> use the new vlan model yet, it only enables these things if a vlan is >> directly configured on it. ?To confirm this can you try a few things: > > My observations confirm your theory: OK, thanks for confirming. The right solution is convert the driver over to the new vlan model. I don't know how soon I might get to this, maybe it's something that the Intel guys can take a look at? > - indeed, -e is necessary to show the vlan tags. So my prior observation > ?regarding tag visibility in tcpdump was wrong. The packets are still > ?have a vlan tag in the non-working case. > > ?(What actually is affected by the txvlan flag is the ability to filter > ?for vlan tags with tcpdump. ?so 'tcpdump -e -i eth0' shows the packets, > ?'tcpdump -e -i eth0 vlan' only shows them with txvlan off. However, > ?filtering for the vlan tag also doesn't work with the vlan interface > ?on eth0.1, while the tagging actually works, as verified above.) Good to know, though that's a separate issue. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/