Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750945Ab1BZBWR (ORCPT ); Fri, 25 Feb 2011 20:22:17 -0500 Received: from mga01.intel.com ([192.55.52.88]:64438 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751Ab1BZBWQ (ORCPT ); Fri, 25 Feb 2011 20:22:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.62,229,1297065600"; d="asc'?scan'208";a="891431123" Subject: Re: TX VLAN acceleration on bridges broken in 2.6.37? From: Jeff Kirsher Reply-To: jeffrey.t.kirsher@intel.com To: Jesse Gross , "Allan, Bruce W" Cc: Jan Niehusmann , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "Tantilov, Emil S" In-Reply-To: References: <20110221232902.GA3440@x61s.reliablesolutions.de> <20110226001908.GA10777@x61s.reliablesolutions.de> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-VwjQZngdhntMAAZvhx/w" Organization: Intel Corporation Date: Fri, 25 Feb 2011 17:22:15 -0800 Message-ID: <1298683335.2643.165.camel@jtkirshe-MOBL1> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 (2.32.1-1.fc14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2613 Lines: 65 --=-VwjQZngdhntMAAZvhx/w Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2011-02-25 at 17:16 -0800, Jesse Gross wrote: > On Fri, Feb 25, 2011 at 4:19 PM, Jan Niehusmann wrote: > > On Fri, Feb 25, 2011 at 02:53:21PM -0800, Jesse Gross wrote: > >> is specific to the e1000e driver. I know that some other Intel NICs > >> require vlan stripping on receive to be enabled for vlan insertion on > >> transmit to work. Since this driver has not been converted over to > >> use the new vlan model yet, it only enables these things if a vlan is > >> directly configured on it. To confirm this can you try a few things: > > > > My observations confirm your theory: >=20 > OK, thanks for confirming. The right solution is convert the driver > over to the new vlan model. I don't know how soon I might get to > this, maybe it's something that the Intel guys can take a look at? I have made sure that Bruce is aware of the issue. We will see what we can do to get some patches created and under testing. >=20 > > - indeed, -e is necessary to show the vlan tags. So my prior observatio= n > > regarding tag visibility in tcpdump was wrong. The packets are still > > have a vlan tag in the non-working case. > > > > (What actually is affected by the txvlan flag is the ability to filter > > for vlan tags with tcpdump. so 'tcpdump -e -i eth0' shows the packets= , > > 'tcpdump -e -i eth0 vlan' only shows them with txvlan off. However, > > filtering for the vlan tag also doesn't work with the vlan interface > > on eth0.1, while the tagging actually works, as verified above.) >=20 > Good to know, though that's a separate issue. --=-VwjQZngdhntMAAZvhx/w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAABAgAGBQJNaFXHAAoJECTsCADr/EWUOEkIAIS+RHFbLCFJ80V5wQoW6jXs h8S8Dx2jsXr83mtY1ZQURubtk6tkyIoVmdRHnTqNFhifqvzpPvuXzlOB3w2oSu3q YVAD+KRu49n4tO0+XmIYmSVmVRVdntTeP6BnwRBvcA0vswE6vvqeX7bW+0xJ8ODU doh7+qwi11ZoE+D88VuvUcQlZqzATEKck/+XOtQ73uT0LOWBz9YiNAUUIy9dqZ04 MTQKCpO1vBrBLB9IUC7VfNOVdsm3RHfhnTz9FZEIE96WsjLsoIME5Ej1GRG/zDU0 9ENE6Jli/zf2yl+L1nBuPqC/vFMF3kqE6s9qz80aRj/rncEuGGaeBgnxI8IOpeo= =9bqc -----END PGP SIGNATURE----- --=-VwjQZngdhntMAAZvhx/w-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/