Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751437Ab1BZGlh (ORCPT ); Sat, 26 Feb 2011 01:41:37 -0500 Received: from LUNGE.MIT.EDU ([18.54.1.69]:59393 "EHLO lunge.queued.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352Ab1BZGlg convert rfc822-to-8bit (ORCPT ); Sat, 26 Feb 2011 01:41:36 -0500 Date: Fri, 25 Feb 2011 22:41:32 -0800 From: Andres Salomon To: Grant Likely Cc: dsd@laptop.org, sparclinux@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH v5] of/promtree: allow DT device matching by fixing 'name' brokenness Message-ID: <20110225224132.0c15eb8a@queued.net> In-Reply-To: References: <20110224165917.3760.24493.stgit@localhost6.localdomain6> <20110224093341.5a809a13@queued.net> <20110224194234.GA8907@angua.secretlab.ca> <20110224120109.0ed9f473@queued.net> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1592 Lines: 34 On Thu, 24 Feb 2011 23:06:06 -0700 Grant Likely wrote: > On Thu, Feb 24, 2011 at 1:01 PM, Andres Salomon > wrote: > > On Thu, 24 Feb 2011 12:42:34 -0700 > > Grant Likely wrote: > >> If firmware is buggy, then pkg2path must deal with it.  It is not > >> okay for it to return NULL.  (I know that pkg2path is an OFW > >> command, but in this context it really means the linux wrapper to > >> pkg2path which has the semantics, "give me the unique, full and > >> accurate path for this node").  If OFW pkg2path doesn't work, then > >> the platform code must work around it.  I'm pushing back on this > >> because I do not want to see platform workarounds in the common > >> code. > > > > I'm fine with that, I just don't want to see BUG() happening that > > early.  I think a workaround should be handled in common code.  I > > agree that heroic workarounds for firmware bugs should be handled in > > arch-specific pkg2path hooks, but a simple workaround in common code > > is better than just crashing early in boot (imo). > > Alright, you've swayed me a bit. I've made this change and pushed it > out to devicetree/experimental. I've also picked up your other patch. > Let me know if it works for you. Thanks, that looks good. Feel free to push into next. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/