From: "Henrik Rydberg" <rydberg@euromail.se>
Date: Sat, 26 Feb 2011 08:36:33 +0100
To: Rafi Rubin <rafi@seas.upenn.edu>
Cc: jkosina@suse.cz, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        micki@n-trig.com, chatty@enac.fr, trivial@kernel.org,
        peter.hutterer@who-t.net
Subject: Re: [PATCH 1/2] HID: ntrig don't dereference unclaimed hidinput
Message-ID: <20110226073633.GA1753@polaris.bitmath.org>
References: <1298610932-21957-1-git-send-email-rafi@seas.upenn.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1298610932-21957-1-git-send-email-rafi@seas.upenn.edu>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 813
Lines: 22

Hi Rafi,

On Fri, Feb 25, 2011 at 12:15:31AM -0500, Rafi Rubin wrote:
> Moved the claimed input check before dereferencing field->hidinput to
> fix a reported invalid deference bug.

How long has this problem been seen? If it is recent, it should
perhaps be fixed in the hid core instead. If it turns out to be an old
problem, please add stable to the Cc.

> Switched to a goto instead of an extra indent for most of the function.

If you put these janitory changes into a separate patch, it will be
much easier to apply the bugfix to stable versions.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/