Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752189Ab1BZMg3 (ORCPT ); Sat, 26 Feb 2011 07:36:29 -0500 Received: from mprc.pku.edu.cn ([162.105.203.9]:47962 "EHLO mprc.pku.edu.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062Ab1BZMg2 (ORCPT ); Sat, 26 Feb 2011 07:36:28 -0500 From: "Guan Xuetao" To: "'Arnd Bergmann'" Cc: , , , "'Greg KH'" References: <015701cbcdae$7d5f43f0$781dcbd0$@mprc.pku.edu.cn> <201102181133.26675.arnd@arndb.de> <019001cbd29c$7cee6340$76cb29c0$@mprc.pku.edu.cn> <201102221811.58441.arnd@arndb.de> In-Reply-To: <201102221811.58441.arnd@arndb.de> Subject: RE: [PATCH 11/12] unicore32 machine related files: ps2 driver Date: Sat, 26 Feb 2011 20:36:16 +0800 Message-ID: <011101cbd5b1$c34f6880$49ee3980$@mprc.pku.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQHwh2GX42xqIG1pSB6ZyMOWdcE4LgISqVFxAqYTC1YCfeub8JOQnp4g Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1670 Lines: 42 > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Wednesday, February 23, 2011 1:12 AM > To: Guan Xuetao > Cc: dmitry.torokhov@gmail.com; linux-kernel@vger.kernel.org; linux-arch@vger.kernel.org; 'Greg KH' > Subject: Re: [PATCH 11/12] unicore32 machine related files: ps2 driver > > On Tuesday 22 February 2011, Guan Xuetao wrote: > > diff --git a/drivers/input/serio/i8042-unicore32io.h b/drivers/input/serio/i8042-unicore32io.h > > index 2cdd872..9350843 100644 > > --- a/drivers/input/serio/i8042-unicore32io.h > > +++ b/drivers/input/serio/i8042-unicore32io.h > > @@ -29,11 +29,11 @@ > > /* > > * Register numbers. > > */ > > -#define I8042_COMMAND_REG ((volatile void __iomem *)&PS2_COMMAND) > > -#define I8042_STATUS_REG ((volatile void __iomem *)&PS2_STATUS) > > -#define I8042_DATA_REG ((volatile void __iomem *)&PS2_DATA) > > +#define I8042_COMMAND_REG PS2_COMMAND > > +#define I8042_STATUS_REG PS2_STATUS > > +#define I8042_DATA_REG PS2_DATA > > I wouldn't bother defining two sets of macros then. Either use PS2_COMMAND > in the driver, or define I8042_COMMAND_REG in the place where you currently > define PS2_COMMAND. All I8042_*_REGs are explicitly defined in i8042-*io.h files. And I want to reserve the original register names in unicore32 namespace. > > Aside from this, it looks good. > > Arnd Thanks & Regards. Guan Xuetao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/