Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751535Ab1BZNtD (ORCPT ); Sat, 26 Feb 2011 08:49:03 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:42294 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914Ab1BZNtB (ORCPT ); Sat, 26 Feb 2011 08:49:01 -0500 Message-ID: <4D6904CB.9020309@linux.vnet.ibm.com> Date: Sat, 26 Feb 2011 08:48:59 -0500 From: Stefan Berger User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 MIME-Version: 1.0 To: Jiri Slaby CC: preining@logic.at, Linux kernel mailing list , Rajiv Andrade , "debora@linux.vnet.ibm.com" Subject: Re: [PATCH v2] tpm_tis: Use timeouts returned from TPM References: <1298403700.25819.7.camel@d941e-10> <4D68E7CA.60704@gmail.com> In-Reply-To: <4D68E7CA.60704@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1498 Lines: 43 On 02/26/2011 06:45 AM, Jiri Slaby wrote: > On 02/22/2011 08:41 PM, Stefan Berger wrote: >> Below patch applies to the tip of the git tree. >> >> v2: >> - adjusting all timeouts for TPM devices reporting too low timeout >> numbers >> - also displaying in sysfs whether the timeouts are 'original' or >> 'adjusted' >> >> The current TPM TIS driver in git discards the timeout values returned >> from the TPM. The check of the response packet needs to consider that >> the return_code field is 0 on success and the size of the expected >> packet is equivalent to the header size + u32 length indicator for the >> TPM_GetCapability() result + 3 timeout indicators of type u32. >> >> Since some TPMs seem to return timeouts in msec rather than usec, >> I am now adjusting all the timeouts rather than just the one for short >> durations. >> >> I am also adding a sysfs entry 'timeouts' showing the timeouts that are >> being used. > It works: 'It' means also 'suspend' works? > # dmesg > [15318.813905] tpm_tis 00:0c: 1.2 TPM (device-id 0xB, rev-id 16) > [15318.879154] tpm_tis 00:0c: Adjusting TPM timeout parameters. > # cat /sys/devices/pnp0/00\:0*/timeouts > 1000000 2000000 150000000 [adjusted] > Looks more reasonable. Stefan > thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/