Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635Ab1BZNtu (ORCPT ); Sat, 26 Feb 2011 08:49:50 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:61774 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123Ab1BZNtt (ORCPT ); Sat, 26 Feb 2011 08:49:49 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=ls2Z2j96BJ9l6ZJbWsnVFsVM94PORogNDyNEOEeJznBaXHD8Mrfs2L1jvM6bBgOE6X P6pdF6lZe+QFpZH6yDrqmWhV+Hv0uK6pYB1bm79j2Xj5daemv7hv98JIDKOzYXCyGDUD WdwVeQ5gNUym/H/kK+j7dWmWp/ctOmpuu80B0= Message-ID: <4D6904F9.7080604@gmail.com> Date: Sat, 26 Feb 2011 14:49:45 +0100 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.2.13) Gecko/20101206 SUSE/3.1.7 Thunderbird/3.1.7 MIME-Version: 1.0 To: Stefan Berger CC: preining@logic.at, Linux kernel mailing list , Rajiv Andrade , "debora@linux.vnet.ibm.com" Subject: Re: [PATCH v2] tpm_tis: Use timeouts returned from TPM References: <1298403700.25819.7.camel@d941e-10> <4D68E7CA.60704@gmail.com> <4D6904CB.9020309@linux.vnet.ibm.com> In-Reply-To: <4D6904CB.9020309@linux.vnet.ibm.com> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1317 Lines: 36 On 02/26/2011 02:48 PM, Stefan Berger wrote: > On 02/26/2011 06:45 AM, Jiri Slaby wrote: >> On 02/22/2011 08:41 PM, Stefan Berger wrote: >>> Below patch applies to the tip of the git tree. >>> >>> v2: >>> - adjusting all timeouts for TPM devices reporting too low timeout >>> numbers >>> - also displaying in sysfs whether the timeouts are 'original' or >>> 'adjusted' >>> >>> The current TPM TIS driver in git discards the timeout values returned >>> from the TPM. The check of the response packet needs to consider that >>> the return_code field is 0 on success and the size of the expected >>> packet is equivalent to the header size + u32 length indicator for the >>> TPM_GetCapability() result + 3 timeout indicators of type u32. >>> >>> Since some TPMs seem to return timeouts in msec rather than usec, >>> I am now adjusting all the timeouts rather than just the one for short >>> durations. >>> >>> I am also adding a sysfs entry 'timeouts' showing the timeouts that are >>> being used. >> It works: > 'It' means also 'suspend' works? Yes. regards, -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/