Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751699Ab1B0HIt (ORCPT ); Sun, 27 Feb 2011 02:08:49 -0500 Received: from swm.pp.se ([212.247.200.143]:34082 "EHLO uplift.swm.pp.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369Ab1B0HIq (ORCPT ); Sun, 27 Feb 2011 02:08:46 -0500 X-Greylist: delayed 402 seconds by postgrey-1.27 at vger.kernel.org; Sun, 27 Feb 2011 02:08:46 EST Date: Sun, 27 Feb 2011 08:02:03 +0100 (CET) From: Mikael Abrahamsson To: Albert Cahalan cc: linux-kernel , netdev@vger.kernel.org Subject: Re: txqueuelen has wrong units; should be time In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (DEB 962 2008-03-14) Organization: People's Front Against WWW MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 22 On Sun, 27 Feb 2011, Albert Cahalan wrote: > Nanoseconds seems fine; it's unlikely you'd ever want > more than 4.2 seconds (32-bit unsigned) of queue. I think this is shortsighted and I'm sure someone will come up with a case where 4.2 seconds isn't enough. Let's not build in those kinds of limitations from start. Why not make it 64bit and go to picoseconds from start? If you need to make it 32bit unsigned, I'd suggest to start from microseconds instead. It's less likely someone would want less than a microsecond of queue, than someone wanting more than 4.2 seconds of queue. -- Mikael Abrahamsson email: swmike@swm.pp.se -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/