Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149Ab1B1Aiq (ORCPT ); Sun, 27 Feb 2011 19:38:46 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:37307 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752029Ab1B1Aio (ORCPT ); Sun, 27 Feb 2011 19:38:44 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; b=DLMQa4A+Qp4TRhFVaW+lW0nQXra/DQDGyRuxIwKVULypWrQopreZVveCRHyNYXn4Pf 9p7eL9rSymaPuzGdyFAVrQFmbwBGeigBDc5IzGMQoBYHSwssccDRPLy54w15lbI63mgB lMOBIDohKdP1krjp3aJvlYlAgRwZJc0q86Tdw= Date: Mon, 28 Feb 2011 03:38:23 +0300 From: Dan Carpenter To: Alessio Igor Bogani Cc: Larry Finger , Chaoming Li , linux-wireless@vger.kernel.org, LKML , Tim Bird Subject: Re: [PATCH] rtlwifi: make gcc happy Message-ID: <20110228003734.GA9075@bicker> Mail-Followup-To: Dan Carpenter , Alessio Igor Bogani , Larry Finger , Chaoming Li , linux-wireless@vger.kernel.org, LKML , Tim Bird References: <1298841390-1194-1-git-send-email-abogani@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1298841390-1194-1-git-send-email-abogani@kernel.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1029 Lines: 20 On Sun, Feb 27, 2011 at 10:16:30PM +0100, Alessio Igor Bogani wrote: > drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’: > drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function > drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function > drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function > These fix actual bugs where uninitialized values are used; it's not just a matter of silencing warnings. The patch title should mention that. Perhaps something like: [patch] rtlwifi: fix places where uninitialized data is used regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/