Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751162Ab1B1GEK (ORCPT ); Mon, 28 Feb 2011 01:04:10 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:34224 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825Ab1B1GEJ (ORCPT ); Mon, 28 Feb 2011 01:04:09 -0500 Date: Mon, 28 Feb 2011 15:04:02 +0900 From: Kukjin Kim Subject: RE: [PATCH 09/09] ARM: s3c2440: gta02: Add touchscreen support In-reply-to: <1297043521-21903-9-git-send-email-lars@metafoo.de> To: "'Lars-Peter Clausen'" , "'Ben Dooks'" Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-id: <000201cbd70d$4f67f1f0$ee37d5d0$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Content-type: text/plain; charset=us-ascii Content-language: ko Content-transfer-encoding: 7BIT Thread-index: AcvGalvZY158vNTMSyCJXP2Ymz3WXgQoI/Fw References: <1297043521-21903-1-git-send-email-lars@metafoo.de> <1297043521-21903-9-git-send-email-lars@metafoo.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2676 Lines: 105 Lars-Peter Clausen wrote: > > This patch registers the s3c touchscreen and adc devices to add touchscreen > support for the gta02. > > Signed-off-by: Lars-Peter Clausen > --- > arch/arm/mach-s3c2440/mach-gta02.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s3c2440/mach-gta02.c b/arch/arm/mach-s3c2440/mach- > gta02.c > index 94456fa..2300ec5 100644 > --- a/arch/arm/mach-s3c2440/mach-gta02.c > +++ b/arch/arm/mach-s3c2440/mach-gta02.c > @@ -79,6 +79,8 @@ > #include > #include > > +#include > + Please group same/similar inclusion together like following. then or In other words, please add your inclusion after other > #include > > #include > @@ -480,6 +482,13 @@ static struct s3c2410_hcd_info gta02_usb_info __initdata > = { > }, > }; > > +/* Touchscreen */ > +static struct s3c2410_ts_mach_info gta02_ts_info = { > + .delay = 10000, > + .presc = 0xff, /* slow as we can go */ > + .oversampling_shift = 2, > +}; How about to use tab between member and = like following? static struct s3c2410_ts_mach_info gta02_ts_info = { .delay = 10000, .presc = 0xff, /* slow as we can go */ .oversampling_shift = 2, }; > + > /* Buttons */ > static struct gpio_keys_button gta02_buttons[] = { > { > @@ -533,6 +542,8 @@ static struct platform_device *gta02_devices[] __initdata > = { > &samsung_asoc_dma, > &s3c_device_i2c0, > >a02_buttons_device, > + &s3c_device_adc, No need to build plat-samsung/dev-adc.c for this? If you want to add '&s3c_deivce_adc', should add 'select SAMSUNG_DEV_ADC' into "config MACH_NEO1973_GTA02". > + &s3c_device_ts, 'select SAMSUNG_DEV_TS' > }; > > /* These guys DO need to be children of PMU. */ > @@ -597,6 +608,7 @@ static void __init gta02_machine_init(void) > #endif > > s3c24xx_udc_set_platdata(>a02_udc_cfg); > + s3c24xx_ts_set_platdata(>a02_ts_info); Same as above. 'select SAMSUNG_DEV_TS' should be added for plat-samsung/dev-ts.c. > s3c_ohci_set_platdata(>a02_usb_info); > s3c_nand_set_platdata(>a02_nand_info); > s3c_i2c0_set_platdata(NULL); > -- > 1.7.2.3 Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/