Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753403Ab1B1K1F (ORCPT ); Mon, 28 Feb 2011 05:27:05 -0500 Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:33066 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753112Ab1B1K1D (ORCPT ); Mon, 28 Feb 2011 05:27:03 -0500 Message-ID: <4D6B78CD.5090602@metafoo.de> Date: Mon, 28 Feb 2011 11:28:29 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Icedove/3.0.11 MIME-Version: 1.0 To: Kukjin Kim CC: "'Ben Dooks'" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/09] ARM: s3c2440: gta02: Remove state_mem constraints for the pcf50633 regulators References: <1297043521-21903-1-git-send-email-lars@metafoo.de> <1297043521-21903-6-git-send-email-lars@metafoo.de> <000401cbd710$6035fab0$20a1f010$%kim@samsung.com> In-Reply-To: <000401cbd710$6035fab0$20a1f010$%kim@samsung.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2539 Lines: 83 On 02/28/2011 07:26 AM, Kukjin Kim wrote: > Lars-Peter Clausen wrote: >> >> The pcf50633 regulator driver does not use the state_mem constraints, so >> there >> is no use in setting them. >> >> Signed-off-by: Lars-Peter Clausen >> --- >> arch/arm/mach-s3c2440/mach-gta02.c | 15 --------------- >> 1 files changed, 0 insertions(+), 15 deletions(-) >> >> diff --git a/arch/arm/mach-s3c2440/mach-gta02.c > b/arch/arm/mach-s3c2440/mach- >> gta02.c >> index e57c4d8..01e0930 100644 >> --- a/arch/arm/mach-s3c2440/mach-gta02.c >> +++ b/arch/arm/mach-s3c2440/mach-gta02.c >> @@ -283,9 +283,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { >> .valid_modes_mask = REGULATOR_MODE_NORMAL, >> .always_on = 1, >> .apply_uV = 1, >> - .state_mem = { >> - .enabled = 1, >> - }, >> }, >> }, >> [PCF50633_REGULATOR_DOWN1] = { >> @@ -304,9 +301,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { >> .valid_modes_mask = REGULATOR_MODE_NORMAL, >> .apply_uV = 1, >> .always_on = 1, >> - .state_mem = { >> - .enabled = 1, >> - }, >> }, >> }, >> [PCF50633_REGULATOR_HCLDO] = { >> @@ -325,9 +319,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { >> .valid_modes_mask = REGULATOR_MODE_NORMAL, >> .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> .apply_uV = 1, >> - .state_mem = { >> - .enabled = 0, >> - }, >> }, >> }, >> [PCF50633_REGULATOR_LDO2] = { >> @@ -362,9 +353,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { >> .valid_modes_mask = REGULATOR_MODE_NORMAL, >> .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> .apply_uV = 1, >> - .state_mem = { >> - .enabled = 1, >> - }, >> }, >> }, >> [PCF50633_REGULATOR_LDO6] = { >> @@ -379,9 +367,6 @@ struct pcf50633_platform_data gta02_pcf_pdata = { >> .min_uV = 1800000, >> .max_uV = 1800000, >> .valid_modes_mask = REGULATOR_MODE_NORMAL, >> - .state_mem = { >> - .enabled = 1, >> - }, >> }, >> }, >> >> -- > > Don't we need regulator_suspend_mem_state_show() on PCF50633? > > No. The pcf50633 driver has no set_suspend_enable or set_suspend_disable ops. So the 'suspend_mem_state' sysfs file does not get registered and that function is never called. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/