Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754072Ab1B1Naf (ORCPT ); Mon, 28 Feb 2011 08:30:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6480 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753790Ab1B1Nae (ORCPT ); Mon, 28 Feb 2011 08:30:34 -0500 Message-ID: <4D6BA377.8070305@redhat.com> Date: Mon, 28 Feb 2011 15:30:31 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 MIME-Version: 1.0 To: Glauber Costa CC: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] expose kvmclock upper msr set. References: <1298483054-1665-1-git-send-email-glommer@redhat.com> <4D6A409E.9010107@redhat.com> <1298899495.15736.321.camel@mothafucka.localdomain> <4D6BA35E.6060504@redhat.com> In-Reply-To: <4D6BA35E.6060504@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 33 On 02/28/2011 03:30 PM, Avi Kivity wrote: > On 02/28/2011 03:24 PM, Glauber Costa wrote: >> On Sun, 2011-02-27 at 14:16 +0200, Avi Kivity wrote: >> > On 02/23/2011 07:44 PM, Glauber Costa wrote: >> > > We've been supporting kvmclock MSRs in the 0x4b564d00-0x4b564dff >> range >> > > for a while now, but we're not exposing it yet, meaning nobody >> is using it. >> > > This simple patch takes care of that. >> > >> > We're exposing them via KVM_GET_SUPPORTED_CPUID, leaf >> KVM_CPUID_FEATURES. >> > >> Our userspace does not really use it, and rely on the capability list. >> Historically, we've been relying on the capabilities mechanism to >> indicate what exists and what does not. > > Yes. I believe this bit marked the change point. > > Anyway, it's exposed, and it's a lot better for userspace to make use > of KVM_GET_SUPPORTED_CPUID since it will work on more kernels. > btw, it should work with -cpu host as well, no? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/