Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754822Ab1B1QPl (ORCPT ); Mon, 28 Feb 2011 11:15:41 -0500 Received: from charlotte.tuxdriver.com ([70.61.120.58]:48781 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754344Ab1B1QPk (ORCPT ); Mon, 28 Feb 2011 11:15:40 -0500 Date: Mon, 28 Feb 2011 11:11:15 -0500 From: "John W. Linville" To: Eric Dumazet Cc: Jussi Kivilinna , Albert Cahalan , Mikael Abrahamsson , linux-kernel , netdev@vger.kernel.org Subject: Re: txqueuelen has wrong units; should be time Message-ID: <20110228161115.GB2515@tuxdriver.com> References: <1298793252.8726.45.camel@edumazet-laptop> <20110227125540.40754c5y78j9u2m8@hayate.sektori.org> <1298837273.8726.128.camel@edumazet-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1298837273.8726.128.camel@edumazet-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 24 On Sun, Feb 27, 2011 at 09:07:53PM +0100, Eric Dumazet wrote: > Qdisc should return to caller a good indication packet is queued or > dropped at enqueue() time... not later (aka : never) > > Accepting a packet at t0, and dropping it later at t0+limit without > giving any indication to caller is a problem. Can you elaborate on what problem this causes? Is it any worse than if the packet is dropped at some later hop? Is there any API that could report the drop to the sender (at least a local one) without having to wait for the ack timeout? Should there be? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/