DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=cYaCTkukEBZ64O304wEncv+ZLibDdeUWq196upagMKLy509ah/hGN9Kd6ZHlnFd0ps
         X/F3/ByyWxVlD5UHWaysl6P68tBHFSG6C2loFcC7lR7x+Jm7vsRx6DFEi3btXFkbyUik
         fJNx2Lm7GWyh5J6Gulw/xqw7qNs0hA2X9NEfI=
Date: Tue, 1 Mar 2011 00:25:54 +0800
From: =?utf-8?Q?Am=C3=A9rico?= Wang <xiyou.wangcong@gmail.com>
To: Daniel J Blueman <daniel.blueman@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, x86@kernel.org
Subject: Re: [2.6.38-rc6] build:mkpiggy fixlet...
Message-ID: <20110228162554.GE25998@cr0.redhat.com>
References: <AANLkTimp0bywKCoqdc8=dZdGmRoOQZoySvjFRLsrk0np@mail.gmail.com>
 <AANLkTimxxTMU3=4ry-_zbY6v1xiDi+hW9y1RegTr8vLK@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTimxxTMU3=4ry-_zbY6v1xiDi+hW9y1RegTr8vLK@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1041
Lines: 37

On Wed, Feb 23, 2011 at 09:33:59AM +0800, Daniel J Blueman wrote:
>Ensure build doesn't silently continue despite read failure,
>addressing a warning due to the unchecked call.
>
>Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
>
>diff --git a/arch/x86/boot/compressed/mkpiggy.c
>b/arch/x86/boot/compressed/mkpiggy.c
>index 646aa78..845a1f8 100644
>--- a/arch/x86/boot/compressed/mkpiggy.c
>+++ b/arch/x86/boot/compressed/mkpiggy.c
>@@ -62,7 +62,12 @@ int main(int argc, char *argv[])
> 	if (fseek(f, -4L, SEEK_END)) {
> 		perror(argv[1]);
> 	}
>-	fread(&olen, sizeof olen, 1, f);
>+
>+	if (fread(&olen, sizeof(olen), 1, f) != 1) {
>+		perror(argv[1]);
>+		return 1;


You need to close the file here...


>+	}
>+		
> 	ilen = ftell(f);
> 	olen = getle32(&olen);
> 	fclose(f);

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/