Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755021Ab1B1UCO (ORCPT ); Mon, 28 Feb 2011 15:02:14 -0500 Received: from relay2.sgi.com ([192.48.179.30]:34557 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754535Ab1B1UCN (ORCPT ); Mon, 28 Feb 2011 15:02:13 -0500 Message-ID: <4D6BFF46.3050001@sgi.com> Date: Mon, 28 Feb 2011 12:02:14 -0800 From: Mike Travis User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Yinghai Lu Cc: Ingo Molnar , David Rientjes , Jack Steiner , Robin Holt , Len Brown , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , linux-acpi@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Linus Torvalds Subject: Re: [PATCH 1/4] printk: Allocate kernel log buffer earlier References: <20110225180633.857892225@gulag1.americas.sgi.com> <20110225180634.017570095@gulag1.americas.sgi.com> <20110227120949.GF16453@elte.hu> <20110227121518.GA19165@elte.hu> <4D6AFBB0.70401@kernel.org> <4D6BF63D.2020404@sgi.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1822 Lines: 51 Yinghai Lu wrote: > On Mon, Feb 28, 2011 at 11:23 AM, Mike Travis wrote: >> >> Yinghai Lu wrote: >>> On 02/27/2011 04:15 AM, Ingo Molnar wrote: >>>> * Ingo Molnar wrote: >>>> >>>>> You could avoid all this ugly workaround of bootmem limitations by >>>>> moving the allocation to memblock_alloc() and desupporting the log_buf_len= >>>>> boot parameter on non-memblock architectures. >>>> memblock_alloc() could return -ENOSYS on architectures that do not >>>> implement it - thus enabling such optional features without ugly #ifdef >>>> CONFIG_HAVE_MEMBLOCK conditionals. >>> Mike, >>> >>> please check updated patch... >>> >>> with the memblock change, you don't need to change acpi SRAT handling etc >>> any more. >> I had to debug a weird ACPI -> Node mapping last week and the >> "improved" SRAT messages helped that considerably. It was >> far easier to spot which Node didn't have the correct assignments. >> I'd submit that patch even without needing fewer (like 512 lines >> max instead of 4096 lines max) bytes in the log buffer. > > Your current change to ACPI srat is not complete yet. > > you only handle x2apic entries. > > According to ACPI 4.0 spec, We should have mixed entries with apic > entries and x2apic entries. > apic entries are for apic id < 255. > x2apic entries are for apic id > 255. > > Yinghai Are you sure you can run both "legacy" and "x2" apic modes in the same SSI under the Intel or AMD rules? (And it's highly probable that you cannot overflow the log buffer with less than 256 CPU's.) Thanks, Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/