Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755153Ab1B1Uh7 (ORCPT ); Mon, 28 Feb 2011 15:37:59 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:56387 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667Ab1B1Uh6 (ORCPT ); Mon, 28 Feb 2011 15:37:58 -0500 Date: Mon, 28 Feb 2011 12:38:35 -0800 (PST) Message-Id: <20110228.123835.245399145.davem@davemloft.net> To: lars.ellenberg@linbit.com Cc: linux-kernel@vger.kernel.org, trivial@kernel.org, holger@eitzenberger.org, kaber@trash.net, netfilter-devel@vger.kernel.org, stable@kernel.org Subject: Re: [patch] fix nla_policy_len to actually _iterate_ over the policy From: David Miller In-Reply-To: <20110228203559.GD8906@barkeeper1-xen.linbit> References: <20110228203559.GD8906@barkeeper1-xen.linbit> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 613 Lines: 17 From: Lars Ellenberg Date: Mon, 28 Feb 2011 21:35:59 +0100 > Currently nla_policy_len always returns n * NLA_HDRLEN: > It loops, but does not advance it's iterator. > NLA_UNSPEC == 0 does not contain a .len in any policy. > > Trivially fixed by adding p++. > > Signed-off-by: Lars Ellenberg Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/