Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 11 Jul 2002 21:41:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 11 Jul 2002 21:41:58 -0400 Received: from perninha.conectiva.com.br ([200.250.58.156]:55567 "HELO perninha.conectiva.com.br") by vger.kernel.org with SMTP id ; Thu, 11 Jul 2002 21:41:53 -0400 Date: Thu, 11 Jul 2002 22:44:35 -0300 From: Arnaldo Carvalho de Melo To: Andrew Morton Cc: Thunder from the hill , Dawson Engler , Linux Kernel Mailing List , mc@cs.Stanford.EDU Subject: Re: [CHECKER] 56 potential lock/unlock bugs in 2.5.8 Message-ID: <20020712014435.GL9541@conectiva.com.br> Mail-Followup-To: Arnaldo Carvalho de Melo , Andrew Morton , Thunder from the hill , Dawson Engler , Linux Kernel Mailing List , mc@cs.Stanford.EDU References: <200207112135.OAA03801@csl.Stanford.EDU> <3D2E211E.24CF19B0@zip.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D2E211E.24CF19B0@zip.com.au> User-Agent: Mutt/1.4i X-Url: http://advogato.org/person/acme Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 855 Lines: 25 Em Thu, Jul 11, 2002 at 05:21:50PM -0700, Andrew Morton escreveu: > Thunder from the hill wrote: > > Here is the whole set. > It's fair enough for a fix I guess. But careful readers will > have observed that a goodly portion of these bugs are directly > due to the poor programming practice of putting more than one > return statement in a C function. woohooo! "gotos considered !harmful" 8) - Arnaldo (that will continue putting more gotos in the kernel (hopefully) where they make sense, _clarifying_ the code and making it more maintainable 8) ) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/