Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756660Ab1CAPdt (ORCPT ); Tue, 1 Mar 2011 10:33:49 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:47237 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412Ab1CAPds (ORCPT ); Tue, 1 Mar 2011 10:33:48 -0500 Subject: Re: [PATCH 3/6] perf record: add time-of-day option From: Peter Zijlstra To: David Ahern Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, acme@ghostprotocols.net, mingo@elte.hu, fweisbec@gmail.com, paulus@samba.org, tglx@linutronix.de In-Reply-To: <4D6D0438.2090901@cisco.com> References: <1298865151-23656-1-git-send-email-daahern@cisco.com> <1298865151-23656-4-git-send-email-daahern@cisco.com> <1298989751.5226.863.camel@laptop> <4D6D0438.2090901@cisco.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 01 Mar 2011 16:35:14 +0100 Message-ID: <1298993714.5226.871.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 37 On Tue, 2011-03-01 at 07:35 -0700, David Ahern wrote: > > On 03/01/2011 07:29 AM, Peter Zijlstra wrote: > > >> +/* add a sample to the event stream based on user request */ > >> +static int perf_event_generate_sample(struct perf_event *event) > >> +{ > >> + struct perf_sample_data data; > >> + struct pt_regs regs; > >> + > >> + perf_fetch_caller_regs(®s); > >> + event->pmu->read(event); > >> + perf_sample_data_init(&data, 0); > >> + data.period = event->hw.last_period; > >> + perf_event_output(event, 0, &data, ®s); > >> + > >> + return 0; > >> +} > > > > I'm not quite sure why you need this.. > > > > periodic samples are generated after the specified period. I want the > first sample immediately and the remainder based on the set period. > > So generically, how do you get the first sample into the event stream > and let the others happen based on the timer? I need not only the > counter value but also the perf_clock timestamp that comes from the > SAMPLE_TIME attribute. Again, why? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/