Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757075Ab1CATdM (ORCPT ); Tue, 1 Mar 2011 14:33:12 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:42165 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752651Ab1CATdK (ORCPT ); Tue, 1 Mar 2011 14:33:10 -0500 Date: Tue, 1 Mar 2011 14:33:07 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Pierre Tardy cc: linux-kernel@vger.kernel.org, , Subject: Re: [linux-pm] [RFC,PATCHv3 0/3] sdhci runtime_pm implementation In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 32 On Tue, 1 Mar 2011, Pierre Tardy wrote: > Please find sdhci runtime_pm implementation. > > It uses clock gating fw as a tip to know when our chip is idle. > It implements wake up from card insertion/removal. > > This is RFC, please dont merge yet. I really would like to have deep review > from PCI linux-pm guys. > > Opens are: > > 1/ Not sure if the pci configs in the driver in rpm_suspend/resume flow > are not duplicate from what the core is doing. There may be one or two small errors. > 2/ Wakeup from D3hot: I cannot find any driver that is implementing it in current upstream, Other drivers do it, but they use PCI PME# instead of interrupts. > I'm not sure if I'm doing it the good way. > We have the exact same issue for our not yet upstreamable usb-otg driver. > Not sure if this cannot be implemented generically in core. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/