Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757338Ab1CATjt (ORCPT ); Tue, 1 Mar 2011 14:39:49 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:22642 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757234Ab1CATjq convert rfc822-to-8bit (ORCPT ); Tue, 1 Mar 2011 14:39:46 -0500 Date: Tue, 1 Mar 2011 11:39:30 -0800 From: Randy Dunlap To: Pekka Enberg Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , gregkh@suse.de Subject: Re: linux-next: Tree for March 1 (staging/winbond) Message-Id: <20110301113930.69d7d992.randy.dunlap@oracle.com> In-Reply-To: References: <20110301181119.f1c7a9c3.sfr@canb.auug.org.au> <20110301104924.071044ef.randy.dunlap@oracle.com> <20110301111922.69b0d8c1.randy.dunlap@oracle.com> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4D6D4B79.00C1:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2192 Lines: 56 On Tue, 1 Mar 2011 21:35:59 +0200 Pekka Enberg wrote: > On Tue, Mar 1, 2011 at 9:19 PM, Randy Dunlap wrote: > > On Tue, 1 Mar 2011 21:10:23 +0200 Pekka Enberg wrote: > > > >> On Tue, Mar 1, 2011 at 8:49 PM, Randy Dunlap wrote: > >> > On Tue, 1 Mar 2011 18:11:19 +1100 Stephen Rothwell wrote: > >> > > >> >> Hi all, > >> >> > >> >> Changes since 20110228: > >> > > >> > > >> > commit ddee7e28e7d5e4ba2b8537c6a59b035745c250bb > >> > Author: Pekka Enberg > >> > Date: ? Sun Nov 28 23:00:01 2010 +0200 > >> > ? ?Staging: w35und: Remove empty sysdef.h header > >> > > >> > > >> > This header should not have been empty, since in > >> > > >> > commit 412dc7f368bf10a8049a8a4c41abbfd0108742e7 > >> > Author: Randy Dunlap > >> > Date: ? Fri Nov 19 09:30:18 2010 -0800 > >> > ? ?staging: fix winbond build, needs delay.h > >> > > >> > I added delay.h to it. ?And now we have the same build > >> > errors that I fixed last November: > >> > > >> > drivers/staging/winbond/phy_calibration.c:986: error: implicit declaration of function 'msleep' > >> > drivers/staging/winbond/phy_calibration.c:1555: error: implicit declaration of function 'udelay' > >> > drivers/staging/winbond/reg.c:893: error: implicit declaration of function 'msleep' > >> > drivers/staging/winbond/reg.c:1169: error: implicit declaration of function 'udelay' > >> > >> Strange. I didn't see the problem. We should add delay.h to > >> phy_calibration.c and reg.c instead. Care to make a patch? > >> -- > > > > No thanks, I'll let the staging people do that. > > Hmm, commit cecf826df8648c843ea8db63b1f82c154a74db36 ("staging: > winbond: needs for msleep and friends") should fix it. > Isn't it in linux-next yet? I'll have to let GregKH answer that. Where is the commit ID from? --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/