Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756908Ab1CBMsJ (ORCPT ); Wed, 2 Mar 2011 07:48:09 -0500 Received: from na3sys009aog102.obsmtp.com ([74.125.149.69]:58609 "EHLO na3sys009aog102.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754721Ab1CBMsH (ORCPT ); Wed, 2 Mar 2011 07:48:07 -0500 From: Santosh Shilimkar References: <1299008793-27428-1-git-send-email-fernando.lugo@ti.com> MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <1299008793-27428-1-git-send-email-fernando.lugo@ti.com> Thread-Index: AcvYSXi8mV0UCCuaQ6ir3E7tyclDJQAjmOQA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 Date: Wed, 2 Mar 2011 18:18:05 +0530 Message-ID: <1dc497a090414bf80ff588791d6db5cc@mail.gmail.com> Subject: RE: [PATCH] omap:iommu-added cache flushing operation for L2 cache To: Fernando Guzman Lugo , hiroshi.doyu@nokia.com Cc: tony@atomide.com, linux@arm.linux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ramesh Gupta , Hari Kanigeri Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2073 Lines: 55 Hello, > -----Original Message----- > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- > owner@vger.kernel.org] On Behalf Of Fernando Guzman Lugo > Sent: Wednesday, March 02, 2011 1:17 AM > To: hiroshi.doyu@nokia.com > Cc: tony@atomide.com; linux@arm.linux.org.uk; linux- > omap@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; Ramesh Gupta; Hari Kanigeri > Subject: [PATCH] omap:iommu-added cache flushing operation for L2 > cache > > From: Ramesh Gupta > > Signed-off-by: Ramesh Gupta > Signed-off-by: Hari Kanigeri > --- > arch/arm/plat-omap/iommu.c | 22 ++++++++-------------- > 1 files changed, 8 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c > index e3eb038..aeb2c33 100644 > --- a/arch/arm/plat-omap/iommu.c > +++ b/arch/arm/plat-omap/iommu.c > @@ -471,22 +471,15 @@ EXPORT_SYMBOL_GPL(foreach_iommu_device); > */ > static void flush_iopgd_range(u32 *first, u32 *last) > { > - /* FIXME: L2 cache should be taken care of if it exists */ > - do { > - asm("mcr p15, 0, %0, c7, c10, 1 @ flush_pgd" > - : : "r" (first)); > - first += L1_CACHE_BYTES / sizeof(*first); > - } while (first <= last); > + dmac_flush_range(first, last); There is note just above this API. /* * These are private to the dma-mapping API. Do not use directly. * Their sole purpose is to ensure that data held in the cache * is visible to DMA, or data written by DMA to system memory is * visible to the CPU. */ #define dmac_map_area cpu_cache.dma_map_area #define dmac_unmap_area cpu_cache.dma_unmap_area #define dmac_flush_range cpu_cache.dma_flush_range > + outer_flush_range(virt_to_phys(first), virt_to_phys(last)); > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/