Date: Wed, 2 Mar 2011 14:28:30 +0100
From: Andrea Righi <arighi@develer.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
        Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        Greg Thelen <gthelen@google.com>,
        Wu Fengguang <fengguang.wu@intel.com>,
        Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
        Ryo Tsuruta <ryov@valinux.co.jp>,
        Hirokazu Takahashi <taka@valinux.co.jp>, Jens Axboe <axboe@kernel.dk>,
        Jonathan Corbet <corbet@lwn.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        containers@lists.linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] blk-throttle: async write throttling
Message-ID: <20110302132830.GB2061@linux.develer.com>
References: <1298888105-3778-1-git-send-email-arighi@develer.com>
 <20110228230114.GB20845@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110228230114.GB20845@redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 5689
Lines: 116

On Mon, Feb 28, 2011 at 06:01:14PM -0500, Vivek Goyal wrote:
> On Mon, Feb 28, 2011 at 11:15:02AM +0100, Andrea Righi wrote:
> > Overview
> > ========
> > Currently the blkio.throttle controller only support synchronous IO requests.
> > This means that we always look at the current task to identify the "owner" of
> > each IO request.
> > 
> > However dirty pages in the page cache can be wrote to disk asynchronously by
> > the per-bdi flusher kernel threads or by any other thread in the system,
> > according to the writeback policy.
> > 
> > For this reason the real writes to the underlying block devices may
> > occur in a different IO context respect to the task that originally
> > generated the dirty pages involved in the IO operation. This makes the
> > tracking and throttling of writeback IO more complicate respect to the
> > synchronous IO from the blkio controller's perspective.
> > 
> > Proposed solution
> > =================
> > In the previous patch set http://lwn.net/Articles/429292/ I proposed to resolve
> > the problem of the buffered writes limitation by tracking the ownership of all
> > the dirty pages in the system.
> > 
> > This would allow to always identify the owner of each IO operation at the block
> > layer and apply the appropriate throttling policy implemented by the
> > blkio.throttle controller.
> > 
> > This solution makes the blkio.throttle controller to work as expected also for
> > writeback IO, but it does not resolve the problem of faster cgroups getting
> > blocked by slower cgroups (that would expose a potential way to create DoS in
> > the system).
> > 
> > In fact, at the moment critical IO requests (that have dependency with other IO
> > requests made by other cgroups) and non-critical requests are mixed together at
> > the filesystem layer in a way that throttling a single write request may stop
> > also other requests in the system, and at the block layer it's not possible to
> > retrieve such informations to make the right decision.
> > 
> > A simple solution to this problem could be to just limit the rate of async
> > writes at the time a task is generating dirty pages in the page cache. The
> > big advantage of this approach is that it does not need the overhead of
> > tracking the ownership of the dirty pages, because in this way from the blkio
> > controller perspective all the IO operations will happen from the process
> > context: writes in memory and synchronous reads from the block device.
> > 
> > The drawback of this approach is that the blkio.throttle controller becomes a
> > little bit leaky, because with this solution the controller is still affected
> > by the IO spikes during the writeback of dirty pages executed by the kernel
> > threads.
> > 
> > Probably an even better approach would be to introduce the tracking of the
> > dirty page ownership to properly account the cost of each IO operation at the
> > block layer and apply the throttling of async writes in memory only when IO
> > limits are exceeded.
> 
> Andrea, I am curious to know more about it third option. Can you give more
> details about accouting in block layer but throttling in memory. So say 
> a process starts IO, then it will still be in throttle limits at block
> layer (because no writeback has started), then the process will write
> bunch of pages in cache. By the time throttle limits are crossed at
> block layer, we already have lots of dirty data in page cache and
> throttling process now is already late?

Charging the cost of each IO operation at the block layer would allow
tasks to write in memory at the maximum speed. Instead, with the 3rd
approach, tasks are forced to write in memory at the rate defined by the
blkio.throttle.write_*_device (or blkio.throttle.async.write_*_device).

When we'll have the per-cgroup dirty memory accounting and limiting
feature, with this approach each cgroup could write to its dirty memory
quota at the maximum rate.

BTW, another thing that we probably need is that any cgroup should be
forced to write their own inodes when the limit defined by dirty_ratio
is exceeded. I mean, avoid to select inodes from the list of dirty
inodes in a FIFO way, but provides a better logic to "assign" the
ownership of each inode to a cgroup (maybe that one that had generated
most of the dirty pages in the inodes) and use for example a list of
dirty inodes per cgroup or something similar.

In this way we should really be able to provide a good quality of
service for the most part of the cases IMHO.

I also plan to write down another patch set to implement this logic.

> 
> > 
> > To summarize, we can identify three possible solutions to properly throttle the
> > buffered writes:
> > 
> > 1) account & throttle everything at block IO layer (bad for "priority
> >    inversion" problems, needs page tracking for blkio)
> > 
> > 2) account at block IO layer and throttle in memory (needs page tracking for
> >    blkio)
> > 
> > 3) account & throttle in memory (affected by IO spikes, depending on
> >    dirty_ratio / dirty_background_ratio settings)
> > 
> > For now we start with the solution 3) that seems to be the simplest way to
> > proceed.
> 
> Yes, IO spikes is the weakness of this 3rd solution. But it should be
> simple too. Also as you said problem can be reduced up to some extent
> by changing reducing dirty_ratio and background dirty ratio But that
> will have other trade offs, I guess.

Agreed.

-Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/