Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754726Ab1CBQM4 (ORCPT ); Wed, 2 Mar 2011 11:12:56 -0500 Received: from na3sys009aog107.obsmtp.com ([74.125.149.197]:52192 "EHLO na3sys009aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752588Ab1CBQMy convert rfc822-to-8bit (ORCPT ); Wed, 2 Mar 2011 11:12:54 -0500 MIME-Version: 1.0 In-Reply-To: <1dc497a090414bf80ff588791d6db5cc@mail.gmail.com> References: <1299008793-27428-1-git-send-email-fernando.lugo@ti.com> <1dc497a090414bf80ff588791d6db5cc@mail.gmail.com> Date: Wed, 2 Mar 2011 10:12:53 -0600 Message-ID: Subject: Re: [PATCH] omap:iommu-added cache flushing operation for L2 cache From: "Gupta, Ramesh" To: Santosh Shilimkar Cc: Fernando Guzman Lugo , hiroshi.doyu@nokia.com, tony@atomide.com, linux@arm.linux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1890 Lines: 52 Hi Santosh, On Wed, Mar 2, 2011 at 6:48 AM, Santosh Shilimkar wrote: > Hello, >> -----Original Message----- >> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- >> owner@vger.kernel.org] On Behalf Of Fernando Guzman Lugo >> Sent: Wednesday, March 02, 2011 1:17 AM >> To: hiroshi.doyu@nokia.com >> Cc: tony@atomide.com; linux@arm.linux.org.uk; linux- >> omap@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >> kernel@vger.kernel.org; Ramesh Gupta; Hari Kanigeri >> Subject: [PATCH] omap:iommu-added cache flushing operation for L2 >> cache >> >> From: Ramesh Gupta >> >> Signed-off-by: Ramesh Gupta >> Signed-off-by: Hari Kanigeri >> --- >> ?arch/arm/plat-omap/iommu.c | ? 22 ++++++++-------------- >> ?1 files changed, 8 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c >> index e3eb038..aeb2c33 100644 >> --- a/arch/arm/plat-omap/iommu.c >> +++ b/arch/arm/plat-omap/iommu.c >> @@ -471,22 +471,15 @@ EXPORT_SYMBOL_GPL(foreach_iommu_device); >> ? */ >> ?static void flush_iopgd_range(u32 *first, u32 *last) >> ?{ >> - ? ? /* FIXME: L2 cache should be taken care of if it exists */ >> - ? ? do { >> - ? ? ? ? ? ? asm("mcr ? ? ? ?p15, 0, %0, c7, c10, 1 @ flush_pgd" >> - ? ? ? ? ? ? ? ? : : "r" (first)); >> - ? ? ? ? ? ? first += L1_CACHE_BYTES / sizeof(*first); >> - ? ? } while (first <= last); >> + ? ? dmac_flush_range(first, last); > > There is note just above this API. Thank you for your inputs. I agree, I will send an updated patch with proper apis. regards Ramesh Gupta G -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/