Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757489Ab1CBUXc (ORCPT ); Wed, 2 Mar 2011 15:23:32 -0500 Received: from tex.lwn.net ([70.33.254.29]:41190 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754997Ab1CBUXb (ORCPT ); Wed, 2 Mar 2011 15:23:31 -0500 X-Greylist: delayed 2031 seconds by postgrey-1.27 at vger.kernel.org; Wed, 02 Mar 2011 15:23:31 EST Date: Wed, 2 Mar 2011 12:49:36 -0700 From: Jake Edge To: Vasiliy Kulikov Cc: linux-kernel@vger.kernel.org, mjt@tls.msk.ru, arnd@arndb.de, mirqus@gmail.com, netdev@vger.kernel.org, Ben Hutchings , David Miller , kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, eric.dumazet@gmail.com, therbert@google.com, xiaosuo@gmail.com, jesse@nicira.com, kees.cook@canonical.com, eugene@redhat.com, dan.j.rosenberg@gmail.com, akpm@linux-foundation.org Subject: Re: [PATCH v2] net: don't allow CAP_NET_ADMIN to load non-netdev kernel modules Message-ID: <20110302124936.289a1915@chukar> In-Reply-To: <20110302194354.GA31043@albatros> References: <201102272122.52643.arnd@arndb.de> <4D6B6AE7.2050202@msgid.tls.msk.ru> <20110228095133.GA4351@albatros> <20110228.112349.104067277.davem@davemloft.net> <20110301194845.GA3533@albatros> <1299010390.2529.30.camel@bwh-desktop> <20110301213313.GA6507@albatros> <20110302194354.GA31043@albatros> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1077 Lines: 28 On Wed, 2 Mar 2011 22:43:54 +0300 Vasiliy Kulikov wrote: > On Wed, Mar 02, 2011 at 12:39 -0700, Jake Edge wrote: > > > @@ -1765,4 +1765,4 @@ module_exit(ipgre_fini); > > > MODULE_LICENSE("GPL"); > > > MODULE_ALIAS_RTNL_LINK("gre"); > > > MODULE_ALIAS_RTNL_LINK("gretap"); > > > -MODULE_ALIAS("gre0"); > > > +MODULE_ALIAS_NETDEV("gre0"); > > > > that is, instead of replacing MODULE_ALIAS("gre0") with the NETDEV > > version, don't you want both for backward compatibility? > > The networking script will run with CAP_NET_ADMIN, this would request > netdev-gre0 and load ip_gre. and on systems that today use CAP_SYS_MODULE (or really the full set of capabilities cuz they are running as root)? won't those try to load gre0 and fail because that alias doesn't exist? jake -- Jake Edge - LWN - jake@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/