Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932133Ab1CCBxY (ORCPT ); Wed, 2 Mar 2011 20:53:24 -0500 Received: from mx4-phx2.redhat.com ([209.132.183.25]:42362 "EHLO mx4-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753300Ab1CCBxX (ORCPT ); Wed, 2 Mar 2011 20:53:23 -0500 Date: Wed, 2 Mar 2011 20:52:37 -0500 (EST) From: CAI Qian To: subrata@linux.vnet.ibm.com Cc: ltp-list@lists.sf.net, vapier@gentoo.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, Paolo Ciarrocchi Message-ID: <1469445745.266603.1299117157337.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> In-Reply-To: <1299068635.4463.1.camel@subratamodak.linux.ibm.com> Subject: Re: [LTP] [ANNOUNCE] The Linux Test Project has been released for FEBRUARY 2011. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.5.72] X-Mailer: Zimbra 6.0.9_GA_2686 (ZimbraWebClient - FF3.0 (Linux)/6.0.9_GA_2686) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3219 Lines: 60 > There was discussion like this some few years back. The idea was to get > some core tests from LTP to the kernel source tree. But then the idea > was dropped probably to avoid maintenance overhead ;-) Where are the places in kernel source tree for those? Those days, there just too many tests and testing projects for kernel like LTP, autotest, xfstests and so on. Why not have somewhere to collabrate and then to extract the best? LTP has so many goals and focus which isn't going to be only to test kernel any more and it is increasing difficult to support so many distros, kernel versions, and so on. There are some CORE tests like memory management tests, ksm, oom etc have benefit from the developers' bless and review. It also need to be updated to keep the tests relevant to the current git tree, since the features/specs are changing consistent inside the kernel. This could be also useful to improve the kernel quality by providing test code inside the kernel tree that to be used during the code review process that for example, a ksm patchset needs to pass that particular sanity tests in order to catch the regression. It provide benefit that when the changelog said that it passed the ksm tests inside the kernel, we knew exactly what it is without needing to sync up with another project like LTP. In term of maintenance, it needs to be selectively which tests need to be inside the kernel. There should ideally have a dedicated maintainer from the testing point of view to review them. The criteria can be something like, 1) purely purpose of the tests are to test kernel written in C with the kernel coding style. Userspace and integration tests should be better to put into LTP and other projects. 2) tests need to pass sub-system maintainers' review that for example, ksm tests need MM sub-system maintainers' review-by and sign-off-by and alike. 3) they need to be working with and sync up to the latest git version. 4) they have to be proved to be the best tests we can have to test those particular kernel code. There are many tests in LTP, but there are also many duplicated tests as well. Those need to be solved when considering to be moved inside the kernel source. 5) they should really be functional testing. Non-functional tests like stress or performance tests are usually more complex to setup hence defeat the purpose of quick regression checking. Once we have those tests in-place, the next step to improve the kernel quality is to have more patches had Tested-by tags before been accepted in the kernel git tree. Those testers can simply use the non-ambiguious references for tests provided by those in-kernel tests. In addition, those could be a follow-up items with the kernel regression reports that after fixed/analyzed a regression in kernel, the next natural thing to do is to fix/add missing tests to close this gap in the future by providing efficient tests to our users if all possible. CAI Qian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/