Message-ID: <4D6F0ED0.80804@kernel.dk>
Date: Wed, 02 Mar 2011 22:45:20 -0500
From: Jens Axboe <axboe@kernel.dk>
MIME-Version: 1.0
To: Vivek Goyal <vgoyal@redhat.com>
CC: Justin TerAvest <teravest@google.com>, Chad Talbott <ctalbott@google.com>,
        Nauman Rafique <nauman@google.com>, Divyesh Shah <dpshah@google.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
        Corrado Zoccolo <czoccolo@gmail.com>
Subject: Re: RFC: default group_isolation to 1, remove option
References: <AANLkTinXa4Zjg0zGbPQRZQi2QW_-0y+PBzQwcdjPLVKZ@mail.gmail.com> <20110301142002.GB25699@redhat.com>
In-Reply-To: <20110301142002.GB25699@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1280
Lines: 29

On 2011-03-01 09:20, Vivek Goyal wrote:
> I think creating per group request pool will complicate the
> implementation further. (we have done that once in the past). Jens
> once mentioned that he liked number of requests per iocontext limit
> better than overall queue limit. So if we implement per iocontext
> limit, it will get rid of need of doing anything extra for group
> infrastructure.
> 
> Jens, do you think per iocontext per queue limit on request
> descriptors make sense and we can get rid of per queue overall limit? 

Since we practically don't need a limit anymore to begin with (or so is
the theory), then yes we can move to per-ioc limits instead and get rid
of that queue state. We'd have to hold on to the ioc for the duration of
the IO explicitly from the request then.

I primarily like that implementation since it means we can make the IO
completion lockless, at least on the block layer side. We still have
state to complete in the schedulers that require that, but it's a good
step at least.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/