Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756569Ab1CCJaH (ORCPT ); Thu, 3 Mar 2011 04:30:07 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:41953 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756096Ab1CCJaE convert rfc822-to-8bit (ORCPT ); Thu, 3 Mar 2011 04:30:04 -0500 From: "TK, Pratheesh Gangadhar" To: Thomas Gleixner , Arnd Bergmann CC: "Hans J. Koch" , "linux-kernel@vger.kernel.org" , "gregkh@suse.de" , "sshtylyov@mvista.com" , "Chatterjee, Amit" , "davinci-linux-open-source@linux.davincidsp.com" , "linux-arm-kernel@lists.infradead.org" Date: Thu, 3 Mar 2011 14:59:42 +0530 Subject: RE: [PATCH v8 1/1] PRUSS UIO driver support Thread-Topic: [PATCH v8 1/1] PRUSS UIO driver support Thread-Index: AcvZHGn2vBdWMnyASoeDeag0ubpRiQAaGU6A Message-ID: References: <1299065886-30099-1-git-send-email-pratheesh@ti.com> <1299065886-30099-2-git-send-email-pratheesh@ti.com> <20110302200956.GB23818@local> <201103022123.38050.arnd@arndb.de> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1292 Lines: 37 Hi, > -----Original Message----- > From: Thomas Gleixner [mailto:tglx@linutronix.de] > Sent: Thursday, March 03, 2011 2:27 AM > On Wed, 2 Mar 2011, Arnd Bergmann wrote: > > > On Wednesday 02 March 2011 21:09:56 Hans J. Koch wrote: > > > > +static struct uio_info *info; > > > > +static dma_addr_t sram_paddr, ddr_paddr; > > > > +static void *prussio_vaddr, *sram_vaddr, *ddr_vaddr; > > > > > > So the correct thing would be > > > > > > static void __iomem *prussio_vaddr; > > > static void *sram_vaddr, *ddr_vaddr; > > > > I also commented that it should not be a global variable at > > all, but a dynamic data structure referenced from the device. > > > > Not important, but Pratheesh said he'd change it. If it stays > > a global variable, I'd at least expect an explanation why > > the static variable is considered better in this case. > > I did not pick at that, because there is no indicator that we'll see > more than one PRUSS unit per SoC in the forseeable future. > It's a possibility - May be in 2-3 years time. Thanks, Pratheesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/