Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757945Ab1CCJfg (ORCPT ); Thu, 3 Mar 2011 04:35:36 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:50291 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757877Ab1CCJfd (ORCPT ); Thu, 3 Mar 2011 04:35:33 -0500 Date: Thu, 3 Mar 2011 10:35:21 +0100 From: Ingo Molnar To: Jan Beulich Cc: Shaohua Li , Andrew Morton , "tglx@linutronix.de" , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , "hpa@zytor.com" Subject: Re: [tip:x86/mm] x86: Work around old gas bug Message-ID: <20110303093521.GD18252@elte.hu> References: <201103012352.p21NqRN1006974@imap1.linux-foundation.org> <4D6E2B8B02000078000347C0@vpn.id2.novell.com> <20110302104144.GB25608@elte.hu> <20110302082453.934f2033.akpm@linux-foundation.org> <1299130025.19589.89.camel@sli10-conroe> <20110302213553.88ec33cd.akpm@linux-foundation.org> <4D6F6C660200007800034AD2@vpn.id2.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D6F6C660200007800034AD2@vpn.id2.novell.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1794 Lines: 52 * Jan Beulich wrote: > >>> On 03.03.11 at 06:35, Andrew Morton wrote: > > On Thu, 03 Mar 2011 13:27:05 +0800 Shaohua Li wrote: > > > >> On Thu, 2011-03-03 at 00:24 +0800, Andrew Morton wrote: > >> > On Wed, 2 Mar 2011 11:41:44 +0100 Ingo Molnar wrote: > >> > > >> > > Meanwhile, what i hate more than ugly code repetition is code that does > > not build at > >> > > all on akpm's test environment ;-) > >> > > >> > I hadn't got around to testing it. Bad news :( > >> > > >> Andrew, > >> can you this on your side? this is what Jan proposed. I can only test a > >> latest binutils here. > > > > Nope. > > > > arch/x86/kernel/entry_64.S: Assembler messages: > > arch/x86/kernel/entry_64.S:985: Error: too many positional arguments > > Indeed - the problem isn't with the actual assembly construct, but > rather with the changed definitions of *INVALIDATE_TLB_VECTOR* - > properly parenthesizing them (as we needed to do in other places) > and removing unnecessary spaces gets this to build for me, even > with the original use of .irp instead of .irpc: > > #if NR_CPUS <= 32 > # define NUM_INVALIDATE_TLB_VECTORS (NR_CPUS) > #else > # define NUM_INVALIDATE_TLB_VECTORS (32) > #endif > > #define INVALIDATE_TLB_VECTOR_END (0xee) > #define INVALIDATE_TLB_VECTOR_START \ > (INVALIDATE_TLB_VECTOR_END-NUM_INVALIDATE_TLB_VECTORS+1) That looks much nicer! Mind sending a patch? I zapped the original non-working workaround from -tip. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/