Date: Thu, 3 Mar 2011 11:44:18 +0100
From: Wim Van Sebroeck <wim@iguana.be>
To: Jamie Iles <jamie@jamieiles.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
        Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [RFC] [PATCH 6/10] Generic Watchdog Timer Driver
Message-ID: <20110303104418.GC3790@infomag.iguana.be>
References: <20110223204350.GA7433@infomag.iguana.be> <20110224100204.GC15118@pulham.picochip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110224100204.GC15118@pulham.picochip.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1250
Lines: 34

Hi Jamie,

> I don't fully understand why the module refcounting is done in the open 
> and release though.  If you moved it into the registration and 
> unregistration then doesn't that remove the need for WDOG_ORPHAN?

Hmm, nice suggestion. Will look into that.

> > diff --git a/drivers/watchdog/core/watchdog_core.c b/drivers/watchdog/core/watchdog_core.c
> > index 52bc520..d1a824e 100644
> > --- a/drivers/watchdog/core/watchdog_core.c
> > +++ b/drivers/watchdog/core/watchdog_core.c
> > @@ -60,6 +60,10 @@ int register_watchdogdevice(struct watchdog_device *wdd)
> >  	if (wdd == NULL || wdd->info == NULL || wdd->ops == NULL)
> >  		return -ENODATA;
> >  
> > +	/* Make sure that the owner of the watchdog operations exists */
> > +	if (wdd->ops->owner == NULL)
> > +		return -ENODATA;
> 
> Won't this be effectively NULL if the module is builtin?  It looks like 
> if it is builtin then THIS_MODULE would be defined as (struct module 
> *)0.

Same for this: I will look into this.

Thanks,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/