Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758051Ab1CCMYv (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Mar 2011 07:24:51 -0500
Received: from smtp.nokia.com ([147.243.1.47]:51623 "EHLO mgw-sa01.nokia.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752078Ab1CCMYu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Mar 2011 07:24:50 -0500
Date: Thu, 3 Mar 2011 14:22:39 +0200 (EET)
From: Aaro Koskinen <aaro.koskinen@nokia.com>
X-X-Sender: aakoskin@esdhcp041196.research.nokia.com
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, stable@kernel.org
Subject: Re: [PATCH] procfs: fix /proc/<pid>/maps heap check
In-Reply-To: <alpine.DEB.1.10.1103031333020.27610@esdhcp041196.research.nokia.com>
Message-ID: <alpine.DEB.1.10.1103031409140.27610@esdhcp041196.research.nokia.com>
References: <1298996813-8625-1-git-send-email-aaro.koskinen@nokia.com> <alpine.DEB.1.10.1103021449000.27610@esdhcp041196.research.nokia.com> <20110303102631.B939.A69D9226@jp.fujitsu.com> <alpine.DEB.1.10.1103031333020.27610@esdhcp041196.research.nokia.com>
User-Agent: Alpine 1.10 (DEB 962 2008-03-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Nokia-AV: Clean
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1655
Lines: 48

Hi,

On Thu, 3 Mar 2011, Aaro Koskinen wrote:
> On Thu, 3 Mar 2011, KOSAKI Motohiro wrote:
>>> On Tue, 1 Mar 2011, Aaro Koskinen wrote:
>>>> The current check looks wrong and prints "[heap]" only if the mapping
>>>> matches exactly the heap. However, the heap may be merged with some
>>>> other mappings, and there may be also be multiple mappings.
>>>> 
>>>> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
>>>> Cc: stable@kernel.org
>
> [...]
>
>> Your description said,
>> 	the heap may be merged with some other mappings,
>>                        ^^^^^^
>> but your example is splitting case. not merge. In other words, your
>> patch care splitting case but break merge case.
>> 
>> Ok, we have no obvious correct behavior. This is debatable. So,
>> Why do you think vma splitting case is important than merge?
>
> Sorry, I was unclear.
>
> The current behaviour is wrong for both merged and split cases, and I
> think the patch fixes both.

Argh, this is confusing. The current check:

 	vma->vm_start <= mm->start_brk && vma->vm_end >= mm->brk

obviously works with the merged case. The patch changes this to:

 	vma->vm_start <= mm->brk && vma->vm_end >= mm->start_brk

This works with the split case, but it does not break the merged case
(or do I miss something still?).

So the current behaviour is broken only with the splitting case. I will
correct the patch description and resend it.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/