Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758234Ab1CCQl3 (ORCPT ); Thu, 3 Mar 2011 11:41:29 -0500 Received: from xenotime.net ([184.105.210.51]:43783 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751471Ab1CCQl2 (ORCPT ); Thu, 3 Mar 2011 11:41:28 -0500 Date: Thu, 3 Mar 2011 08:41:25 -0800 From: Randy Dunlap To: Wolfram Sang Cc: Li Zefan , Jinqiu , linux-kernel@vger.kernel.org Subject: Re: [patch] Fix bug #13853: dereference pointer 'dev' before null check Message-Id: <20110303084125.57f43b81.rdunlap@xenotime.net> In-Reply-To: <20110303081156.GA14163@pengutronix.de> References: <4D6EFAE5.4000400@gmail.com> <4D6F01DA.3040307@cn.fujitsu.com> <20110303081156.GA14163@pengutronix.de> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1112 Lines: 30 On Thu, 3 Mar 2011 09:11:56 +0100 Wolfram Sang wrote: > Hi, > > > Don't ever mention "bug #13853", because this number makes no sense > > for everyone except you. A proper subject may be: > > > > [PATCH] ariadne: fix possible null dereference. > > I agree for the subject line. Still, in the body or maybe after the "---" I'd > think it makes sense, so it is known there is a bugzilla entry to close? Also, > using search engines, one will be able to dig up the patch. It should just refer to the full bugzilla #13853 URL: https://bugzilla.kernel.org/show_bug.cgi?id=13853 > > And please send your patches to proper maintainers and mailing list, > > David Miller and netdev@vger.kernel.org in particular. > > Yup. Using scripts/get_maintainers.pl is the way to go here. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/