Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758601Ab1CCRqK (ORCPT ); Thu, 3 Mar 2011 12:46:10 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:56177 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758465Ab1CCRqI (ORCPT ); Thu, 3 Mar 2011 12:46:08 -0500 MIME-Version: 1.0 In-Reply-To: <1299137483-10975-1-git-send-email-ksumrall@android.com> References: <1299137483-10975-1-git-send-email-ksumrall@android.com> From: Linus Torvalds Date: Thu, 3 Mar 2011 09:45:38 -0800 Message-ID: Subject: Re: [PATCH] Syscalls: reboot: Add options to the reboot syscall to remount filesystems ro To: Ken Sumrall Cc: linux-kernel@vger.kernel.org, Alexander Viro , Christoph Hellwig , Andrew Morton , Jan Kara , Jens Axboe , Matthew Wilcox , Eric Paris , Dave Young , Jiri Slaby , James Morris , linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 21 On Wed, Mar 2, 2011 at 11:31 PM, Ken Sumrall wrote: > > Add 4 new commands to the reboot system call, that do the same thing as the > RESTART, HALT, POWER_OFF, and RESTART2 commands, but also remount writable > filesystems as read-only just before doing what the command normally does. This makes no sense. If you can change whatever user-land process that does the reboot system call (and clearly you can, since you're adding new commands and using those), then why the heck don't you just do the remount-ro from that same user land? How many mounted filesystems do you have that it's so hard to keep track of? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/