From: Arnd Bergmann <arnd@arndb.de>
To: Pratheesh Gangadhar <pratheesh@ti.com>
Subject: Re: [PATCH v9 1/1] PRUSS UIO driver support
Date: Thu, 3 Mar 2011 19:15:55 +0100
User-Agent: KMail/1.13.5 (Linux/2.6.38-rc6+; KDE/4.5.1; x86_64; ; )
Cc: linux-kernel@vger.kernel.org, hjk@hansjkoch.de, gregkh@suse.de,
        tglx@linutronix.de, sshtylyov@mvista.com, amit.chatterjee@ti.com,
        davinci-linux-open-source@linux.davincidsp.com,
        linux-arm-kernel@lists.infradead.org
References: <1299175677-17859-1-git-send-email-pratheesh@ti.com> <1299175677-17859-2-git-send-email-pratheesh@ti.com>
In-Reply-To: <1299175677-17859-2-git-send-email-pratheesh@ti.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201103031915.55825.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 876
Lines: 27

On Thursday 03 March 2011 19:07:57 Pratheesh Gangadhar wrote:
> +struct uio_pruss_dev {
> +       struct uio_info *info;
> +       struct clk *pruss_clk;
> +       dma_addr_t sram_paddr;
> +       dma_addr_t ddr_paddr;
> +       void __iomem *prussio_vaddr;
> +       void *sram_vaddr;
> +       void *ddr_vaddr;
> +       unsigned int hostirq_start;
> +       unsigned int pintc_base;
> +};
> +
> +struct pruss_priv {
> +       struct uio_pruss_dev *pupdev;
> +};

I cannot see the point of struct pruss_priv, I think it would be better to
just merge the two data structures into one. Everything else looks
good to me now.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/