Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758652Ab1CCSRu (ORCPT ); Thu, 3 Mar 2011 13:17:50 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:47435 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758464Ab1CCSRt (ORCPT ); Thu, 3 Mar 2011 13:17:49 -0500 Subject: Re: [PATCH] Make /proc/slabinfo 0400 From: Dave Hansen To: Dan Rosenberg Cc: cl@linux-foundation.org, penberg@kernel.org, mpm@selenic.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <1299174652.2071.12.camel@dan> References: <1299174652.2071.12.camel@dan> Content-Type: text/plain; charset="ISO-8859-1" Date: Thu, 03 Mar 2011 10:17:46 -0800 Message-ID: <1299176266.8493.2369.camel@nimitz> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 931 Lines: 26 On Thu, 2011-03-03 at 12:50 -0500, Dan Rosenberg wrote: > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4691,7 +4691,7 @@ static const struct file_operations proc_slabinfo_operations = { > > static int __init slab_proc_init(void) > { > - proc_create("slabinfo", S_IRUGO, NULL, &proc_slabinfo_operations); > + proc_create("slabinfo", S_IRUSR, NULL, &proc_slabinfo_operations); > return 0; > } > module_init(slab_proc_init); Please don't. In reality, it'll just mean that more data collection things will have to get done as root, and I'll wear my keyboard out more often sudo'ing. If you really want this on particularly pedantic systems, why not chmod? -- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/