Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758684Ab1CCTX5 (ORCPT ); Thu, 3 Mar 2011 14:23:57 -0500 Received: from xenotime.net ([184.105.210.51]:51809 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752319Ab1CCTX4 (ORCPT ); Thu, 3 Mar 2011 14:23:56 -0500 Date: Thu, 3 Mar 2011 11:23:47 -0800 From: Randy Dunlap To: Jinqiu Cc: linux-kernel@vger.kernel.org Subject: Re: [patch] Fix bug #13853: dereference pointer 'dev' before null check Message-Id: <20110303112347.12059596.rdunlap@xenotime.net> In-Reply-To: <4D6EFAE5.4000400@gmail.com> References: <4D6EFAE5.4000400@gmail.com> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1434 Lines: 44 On Wed, 02 Mar 2011 21:20:21 -0500 Jinqiu wrote: > This patch fixes bug #13853 .This still exists in latest version. > 'dev' is dereferenced before testing for NULL. > > Signed-off-by: Jinqiu Yang > --- a/drivers/net/ariadne.c > +++ b/drivers/net/ariadne.c > @@ -420,7 +420,7 @@ static inline void ariadne_reset(struct > static irqreturn_t ariadne_interrupt(int irq, void *data) > { It looks like thunderbird has split a long line into multiple lines for you. This is bad. See if Documentation/email-clients.txt can help you out any. > struct net_device *dev = (struct net_device *) data; > - volatile struct Am79C960 *lance = (struct Am79C960*)dev->base_addr; > + volatile struct Am79C960 *lance; > struct ariadne_private *priv; > int csr0, boguscnt; > int handled = 0; > @@ -429,6 +429, 7 @@ static irqreturn_t ariadne_interrupt(int > printk(KERN_WARNING "ariadne_interrupt(): irq for unknown device.\n"); > return IRQ_NONE; > } > + lance = (struct Am79C960 *)dev->base_addr; > > lance->RAP = CSR0; /* PCnet-ISA Controller Status */ > > > > > -- --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/