Subject: Re: [PATCH 2/3] ptp: add a software clock based on
 clock_monotonic_raw
From: john stultz <johnstul@us.ibm.com>
To: Torben Hohn <torbenh@gmx.de>
Cc: linux-kernel@vger.kernel.org, richard.cochran@omicron.at,
        tglx@linutronix.de
In-Reply-To: <1299173174-348-3-git-send-email-torbenh@gmx.de>
References: <1299173174-348-1-git-send-email-torbenh@gmx.de>
	 <1299173174-348-3-git-send-email-torbenh@gmx.de>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 03 Mar 2011 11:34:04 -0800
Message-ID: <1299180844.28285.111.camel@work-vm>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1126
Lines: 35

On Thu, 2011-03-03 at 18:26 +0100, Torben Hohn wrote:
> First version of a software clock. Not very useful yet,
> as it doesnt generate events, but at least it allows
> for testing the ptp framework without special hardware.

So in the past, I pushed back on Richard for having something similar,
as I'm not psyched about duplicating interfaces. However, your
implementation is CLOCK_MONOTONIC_RAW instead of CLOCK_REALTIME and it
keeps the adjustments internal, I'm not as opposed.

So I think having such test driver is probably reasonable, but please
make it more explicit that it is just a testing driver, and not
something someone should try to use.

> +
> +struct ixp_clock {
> +	struct ptp_clock *ptp_clock;
> +	struct ptp_clock_info caps;
> +	s64 offset_ns;
> +	struct timespec last_timestamp;
> +	s32 freq;
> +};

Probably should rename things from ixp_*


thanks
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/