Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759587Ab1CDM05 (ORCPT ); Fri, 4 Mar 2011 07:26:57 -0500 Received: from proxy.DResearch.DE ([87.193.137.100]:57740 "EHLO mail.dresearch.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751999Ab1CDM0z (ORCPT ); Fri, 4 Mar 2011 07:26:55 -0500 Message-ID: <4D70DA8D.9070603@dresearch.de> Date: Fri, 04 Mar 2011 13:26:53 +0100 From: Steffen Sledz User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2.14) Gecko/20110221 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: Alan Cox CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , Mario Schuknecht , Steffen Sledz Subject: Re: [PATCH v2] tcp: ioctl type SIOCOUTQNSD returns amount of data not sent References: <201103041057.53671.arnd@arndb.de> <1299234031-13937-1-git-send-email-sledz@dresearch.de> In-Reply-To: <1299234031-13937-1-git-send-email-sledz@dresearch.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 04 Mar 2011 12:26:54.0367 (UTC) FILETIME=[7242FAF0:01CBDA67] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1661 Lines: 45 Am 04.03.2011 12:49, schrieb Alan Cox: > ... >>> Signed-off-by: Mario Schuknecht >>> --- >>> include/asm-generic/ioctls.h | 1 + >>> include/linux/sockios.h | 1 + >>> net/ipv4/tcp.c | 9 +++++++++ >>> 3 files changed, 11 insertions(+), 0 deletions(-) >>> >>> diff --git a/include/asm-generic/ioctls.h b/include/asm-generic/ioctls.h >>> index a321665..b87115b 100644 >>> --- a/include/asm-generic/ioctls.h >>> +++ b/include/asm-generic/ioctls.h >>> @@ -72,6 +72,7 @@ >>> #define TCSETXF 0x5434 >>> #define TCSETXW 0x5435 >>> #define TIOCSIG _IOW('T', 0x36, int) /* pty: generate signal */ >>> +#define TIOCOUTQNSD 0x5437 > > These are tty not socket ioctl codes. For various historical reasons some > of them got sort of emulated by the socket layer in Unix and thus in > Linux. > > If you plan to add one to Linux then please post the accompanying *tty > layer* patches and reasoning, otherwise if it is socket only please stick > to the socket ioctl. So we should define the new SIOCOUTQNSD in sockios.h only and not similiar to SIOCOUTQ using TIOCOUTQ. Right? Steffen -- DResearch Fahrzeugelektronik GmbH Otto-Schmirgal-Str. 3, 10319 Berlin, Germany Tel: +49 30 515932-237 mailto:sledz@DResearch.de Fax: +49 30 515932-299 Gesch?ftsf?hrer: Dr. Michael Weber, Werner M?gle; Amtsgericht Berlin Charlottenburg; HRB 130120 B; Ust.-IDNr. DE273952058 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/