Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759573Ab1CDMnO (ORCPT ); Fri, 4 Mar 2011 07:43:14 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:41918 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884Ab1CDMnN convert rfc822-to-8bit (ORCPT ); Fri, 4 Mar 2011 07:43:13 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=dHFJ1cTD9ABKSsf4RO1K2UPnzmzwrH6nvBnN1b4NeBxM27/atkP41HXdkifAJLTOZw JI5qiY4+GRRDN30/DaUNiGc8olVa0+ok32ozZZh+Oi1yZVAm+pW4RqMOGdBRZ/BSyxkq U+jynaIcHNZfrzGToLWfWKs4xkCBiyQLOzwyc= MIME-Version: 1.0 In-Reply-To: <1299239923-7092-1-git-send-email-henne@nachtwindheim.de> References: <1299239923-7092-1-git-send-email-henne@nachtwindheim.de> Date: Fri, 4 Mar 2011 15:43:12 +0300 Message-ID: Subject: Re: [PATCHv2 1/7] x86: remove superflous goal definition of tsc_sync From: Cyrill Gorcunov To: Henrik Kretzschmar Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1495 Lines: 42 On Fri, Mar 4, 2011 at 2:58 PM, Henrik Kretzschmar wrote: > This goal definition is superflous. > CONFIG_X86_64_SMP depends on CONFIG_SMP > and tsc_sync.o is already in the definition of CONFIG_SMP. > > Signed-off-by: Henrik Kretzschmar > --- > ?arch/x86/kernel/Makefile | ? ?1 - > ?1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile > index 4ad4509..6b61081 100644 > --- a/arch/x86/kernel/Makefile > +++ b/arch/x86/kernel/Makefile > @@ -69,7 +69,6 @@ obj-$(CONFIG_APM) ? ? ? ? ? ? += apm.o > ?obj-$(CONFIG_SMP) ? ? ? ? ? ? ?+= smp.o > ?obj-$(CONFIG_SMP) ? ? ? ? ? ? ?+= smpboot.o tsc_sync.o > ?obj-$(CONFIG_SMP) ? ? ? ? ? ? ?+= setup_percpu.o > -obj-$(CONFIG_X86_64_SMP) ? ? ? += tsc_sync.o > ?obj-$(CONFIG_X86_MPPARSE) ? ? ?+= mpparse.o > ?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ?+= apic/ > ?obj-$(CONFIG_X86_REBOOTFIXUPS) += reboot_fixups_32.o > -- > 1.7.2.3 > > Probably we better write it this way: - obj-$(CONFIG_SMP) += smpboot.o tsc_sync.o - obj-$(CONFIG_X86_64_SMP) += tsc_sync.o + obj-$(CONFIG_SMP) += smpboot.o + obj-$(CONFIG_SMP) += tsc_sync.o I guess this would be cleaner? Ingo? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/