Date: Fri, 4 Mar 2011 17:13:53 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: chris.mason@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [RFC] a couple of i_nlink fixes in btrfs
Message-ID: <20110304171353.GU22723@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 711
Lines: 13

	a) rename() plays with i_nlink of old_inode; bad, since it's not
locked.  I'd add a variant of btrfs_unlink_inode() that would leave
btrfs_drop_nlink()/btrfs_update_inode() to callers and use it instead.
	b) btrfs_link() doesn't check for i_nlink overflows.  I don't
know if there's anything preventing that many links to a file on btrfs,
but if there is, it's at least worth a comment in there...

	Please, review; patches in followups or in #btrfs in vfs-2.6.git
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/