Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760112Ab1CDUBD (ORCPT ); Fri, 4 Mar 2011 15:01:03 -0500 Received: from imr3.ericy.com ([198.24.6.13]:51062 "EHLO imr3.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757720Ab1CDUBB (ORCPT ); Fri, 4 Mar 2011 15:01:01 -0500 Subject: Re: [PATCH v5 00/11] hwmon: (w83627ehf) Add support for NCT6775F and NCT6776F From: Guenter Roeck Reply-To: guenter.roeck@ericsson.com To: Andrew Lutomirski CC: Jean Delvare , Ian Dobson , Randy Dunlap , "binximeng@gmail.com" , "lmsensors@tapanitarvainen.fi" , "andrea.rizzolo@gmail.com" , "jeff.sadowski@gmail.com" , "lm-sensors@lm-sensors.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: References: <1299261486-15190-1-git-send-email-guenter.roeck@ericsson.com> Content-Type: text/plain; charset="UTF-8" Organization: Ericsson Date: Fri, 4 Mar 2011 11:59:57 -0800 Message-ID: <1299268797.18605.71.camel@groeck-laptop> MIME-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 39 On Fri, 2011-03-04 at 13:50 -0500, Andrew Lutomirski wrote: > On Fri, Mar 4, 2011 at 12:57 PM, Guenter Roeck > wrote: > > The following patch series adds support for NCT6775F and NCT6776F to the > > w83627ehf driver. It also includes some cleanup and adds support for > > the fourth temperature sensor on W83677HG-B. > > > > No code changes since v4. Resubmitting and widening audience in the hope that > > someone may find the time to review the changes prior to the next commit window. > > I'm not sure my review is worth much, but the driver seems to work. I've tested > fan speed measurement, changing pwm2_enable to 1, changing the fan speed, > and changing back to 5. Everything looks good. > > The only weird thing I noticed is that, the first time I ran sensors, I got: > fan2: 0 RPM (min = 0 RPM, div = 64) > and thereafter I get > fan2: 136 RPM (min = 0 RPM, div = 64) ALARM > > I suspect (although I haven't checked) that sensors is just reading > div after it's already changed to 64. > The driver reads rpm, finds it to be zero, and increases div as result (NCT6775F may report zero rpm if div is too low). That explains the first reading. What I don't understand is the alarm you get with the 2nd reading. Any idea where this might come from ? Is it sticky, or do you see it only once ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/