Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760673Ab1CEBRk (ORCPT ); Fri, 4 Mar 2011 20:17:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63481 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760313Ab1CEBRi (ORCPT ); Fri, 4 Mar 2011 20:17:38 -0500 Message-ID: <4D718F2D.6080105@redhat.com> Date: Fri, 04 Mar 2011 20:17:33 -0500 From: Zachary Amsden User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 MIME-Version: 1.0 To: Nikola Ciprich CC: Glauber Costa , Avi Kivity , Nikola Ciprich , KVM list , Linux kernel list Subject: Re: regression - 2.6.36 -> 2.6.37 - kvm - 32bit SMP guests don't boot References: <20110303070652.GG29840@pcnci.linuxbox.cz> <4D6FFE5D.1030401@redhat.com> <20110303210647.GA27691@nik-comp.lan> <4D700F09.9000002@redhat.com> <20110303220155.GB27691@nik-comp.lan> <4D7101AF.6060009@redhat.com> <20110304182733.GA2867@nik-comp.lan> <1299265762.11618.140.camel@mothafucka.localdomain> <20110304205512.GB2867@nik-comp.lan> <1299274906.11618.157.camel@mothafucka.localdomain> <20110304223640.GC2867@nik-comp.lan> In-Reply-To: <20110304223640.GC2867@nik-comp.lan> Content-Type: multipart/mixed; boundary="------------030908070504070202080200" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1732 Lines: 53 This is a multi-part message in MIME format. --------------030908070504070202080200 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 03/04/2011 05:36 PM, Nikola Ciprich wrote: >> I think although the long term plan is to just do this update once in >> your case (stable tsc), this update is needed. >> >> Why don't you send a patch to re-include it ? >> >> > Yes, I'll gladly submit patch, one question, is this OK > to just add calling kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu) before > the conditional (as I did in my test), or should it go somewhere to else {..} > section? it's called inside the conditional again, which will cause it > to be called twice in some cases, is it OK? > n. > > Can you try this patch to see if it fixes the problem? Thanks, Zach --------------030908070504070202080200 Content-Type: text/plain; name="guest-time-test.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="guest-time-test.patch" diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 468fafa..ba05303 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1866,6 +1866,7 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) } kvm_x86_ops->vcpu_load(vcpu, cpu); + kvm_request_guest_time_update(vcpu); if (unlikely(vcpu->cpu != cpu)) { /* Make sure TSC doesn't go backwards */ s64 tsc_delta = !vcpu->arch.last_host_tsc ? 0 : --------------030908070504070202080200-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/